Release: the publish job's id-token: write is reachable by npm install scripts; split build from publish
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 42/100
- Tipo di issue
- Refactoring
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- github-actions, typescript
Direzione di ricerca
Start with .github/workflows/release-cli.yml and compare the release flow with the credential handling in #282. Trace the publish steps and downstream jobs, then check scripts/attach-release-provenance.mjs and how the rerun check uses gitHead. Done means the workflow separates build, publish, and release permissions, verifies the downloaded tarball, and preserves the provenance and release checks.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Design note, follow-up to #281 / #282.
Problem
In .github/workflows/release-cli.yml, the publish job has id-token: write (and contents: write) for the whole job. While a job has id-token: write, every step in it gets ACTIONS_ID_TOKEN_REQUEST_URL and ACTIONS_ID_TOKEN_REQUEST_TOKEN in its environment. Any code running in that job can use them to request a GitHub OIDC token for this workflow, and that token is what npm trusted publishing accepts for @diffci.com/diffci.
The same job then runs third-party code before it publishes:
npm ci --no-audit --fund=falseinpackages/diffci-cli, with install scripts enabled. That covers the dependencies'preinstall/install/postinstallscripts, and thepreparebuild of the@diffci.com/coregit dependency together with its own dependencies.npm install --global npm@11, which is an unpinned version range.npm run typecheck,build,package:check,package:smoke, and thennpm publish, which runs the package'sprepacklifecycle.
A compromised dependency could therefore publish a version of @diffci.com/diffci that carries a valid provenance attestation for this repository. #282 keeps the contents: write token out of .git/config, but it cannot help with the OIDC credential: that one comes from the job's permissions, not the checkout.
Proposal: split the job
buildjob (permissions: contents: read, noid-token). It holds every step that installs or runs code: tag check,npm ci,check-agent-packaging, typecheck, build,package:check,package:smoke. It then runsnpm packand uploads the tarball (and its sha512/integrity) withactions/upload-artifact.publishjob (needs: build,permissions: id-token: writeonly,environment:optional). It does not runnpm cior any install or lifecycle scripts. It sets up Node and npm (ideally with a pinned npm version) and downloads the artifact. It checks the tarball against the recorded digest, then runs the existing "already published from this commit" check andnpm publish <tarball> --access public --provenance --ignore-scripts.- Release job(s) for the steps that need
contents: write: wait for propagation, observer Action smoke, GitHub Release, provenance assets,action-vtag,verify-release. These run afterpublishwithoutid-token: write. They can keepcontents: writewithpersist-credentials: falseas in #282.
The downstream jobs (publish-gitlab-component, publish-mcp-registry, notify-hosted-mcp) would need needs: updated to the new final job.
Things to check while doing it
- gitHead: the existing re-run check compares the published
gitHeadwithGITHUB_SHA. When publishing from a folder in a git checkout, npm fillsgitHeadin itself. That field needs confirming fornpm publish <tarball>, or the check needs to be kept another way, for example by recording the commit in the artifact. - Provenance subject: the attestation names the tarball's sha512.
scripts/attach-release-provenance.mjsalready checks that subject against what npm serves, so it should keep passing unchanged. - Tarball contents:
npm packin the build job runsprepack(build:client) without the OIDC credential, so the tarball contents stay the same as today'snpm publish.
Related: #281, #282.
- Lingua principale
- TypeScript
- Stelle
- 0
- Fork
- 4
- Merge medio
- 18h 41m
- PR unite (30g)
- 48
Preparare l'ambiente
Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di DiffCI/core
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
Planner: splitParts regex is quadratic on a quote followed by many backticks, so the fuzz test fails at randomForse già presa @FredApps l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 86/100
I maintainer di solito rispondono entro 1 giorno
-
Agent tools: changed_files lists only the new path of a renamed fileForse già presa @FredApps l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
DiffCI/core#243 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
adapter good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
I maintainer di solito rispondono entro 1 giorno
Issue simili
-
agent-ready area: ui-server priority: p3 type: test
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
schlessera/brain-kit#4249 ·
I maintainer di solito rispondono entro 1 giorno
-
documentation tool triaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
can1357/oh-my-pi#19608 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
dependencies tech-debt
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
bcgov/nr-waste-plus#1549 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
blixvip/solana-token-meta#17 ·
-
enhancement good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
blixvip/solana-tx-parse#18 ·