Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[correctness][missing-coverage][sort] Mixed files and repeated stdin lack a combined regression

Chiusa Adatta ai principianti
  • Qualcosa non va?
#638 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
78/100
Tipo di issue
Documentazione
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
go
Ambito
testing

Direzione di ricerca

Leggi gli scenari sort esistenti, in particolare TestSortStdinDash, TestSortMultipleFiles e i test dei record senza terminatore, quindi aggiungi la regressione in tests/scenarios/cmd/sort/basic/mixed_files_repeated_stdin.yaml. Usa il fixture e il riproduttore dell’issue per coprire insieme file, operandi - ripetuti e un record senza terminatore; il lavoro è completato quando lo scenario passa e corrisponde al comportamento di GNU coreutils.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Generated by the rshell behavior correctness scanner.

  • Contract: BEH-004
  • Classification: missing-coverage
  • Impact: low
  • Target: sort
  • Scanned commit: 514d1cb8188fda6b1accca5955dfab3b0e8aa34a

Existing tests cover files, stdin, explicit -, and unterminated records separately, but lack a regression combining files with repeated stdin operands and unterminated records. The tested implementation correctly preserves record boundaries and consumes stdin once; no defect was demonstrated.

Contract sources
  • docs/BEHAVIOR_CONTRACTS.md:45-49: Files, stdin, -, multiple operands, and pipes must interact like the selected reference.
  • sort --help: Help says files are concatenated for sorting and - reads standard input.
Implementation references
  • builtins/sort/sort.go:372-388: Reads each operand independently before combining its records.
  • builtins/sort/sort.go:427-446: Each - operand reads the shared stdin stream.

Fixture setup

For each run, create a fresh zz_correctness_scan_ directory and run from it. Set zz_correctness_scan_dir to its absolute path. Create zz_correctness_scan_a.txt containing exactly c\nb with no final newline, and zz_correctness_scan_b.txt containing exactly e\n.

Reproducer

printf 'd\na' | sort -- zz_correctness_scan_a.txt - - zz_correctness_scan_b.txt

Commands used:

  • GOENV_VERSION=1.26.3 timeout 300s go build -o /tmp/zz_correctness_scan_rshell ./cmd/rshell
  • /tmp/zz_correctness_scan_rshell --allowed-commands rshell:sort,rshell:printf --allowed-paths "$zz_correctness_scan_dir" -c "printf 'd\na' | sort -- zz_correctness_scan_a.txt - - zz_correctness_scan_b.txt"
  • LC_ALL=C bash -c "printf 'd\na' | sort -- zz_correctness_scan_a.txt - - zz_correctness_scan_b.txt"
  • GOENV_VERSION=1.26.3 timeout 300s go test ./tests -run '^TestShellScenarios$/^cmd$/^sort$/^(basic|flags|errors|help|pathological|zz_correctness_scan_cases)$' -count=2 -timeout 240s

Verification

  • Reproduction runs: 2
  • Reference: Matched native GNU coreutils 9.4 twice from clean fixtures. The temporary scenario passed both focused scenario runs. Reviewed TestSortStdinDash, TestSortMultipleFiles, and unterminated-record tests; none cover this interaction.
  • Temporary test: tests/scenarios/cmd/sort/zz_correctness_scan_cases/zz_correctness_scan_mixed_sources.yaml; removed after verification. Script, stdout, and stderr used YAML |+ scalars.
  • Suggested regression-test location: tests/scenarios/cmd/sort/basic/mixed_files_repeated_stdin.yaml

Fingerprint: 0cd34bdf1a7770a89bc2569e53707147145f3a4334a30322ad61c107162d3113

Lingua principale
Go
Stelle
31
Fork
3
Merge medio
2g 23h
PR unite (30g)
13

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DataDog/rshell

Tutte le issue di DataDog/rshell

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.