Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[Feature]: Low-rate, self-triggering TCs are reported Delayed/Timing-out by definition, even when data is complete

Aperta
  • Qualcosa non va?
#446 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
65/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cpp
Ambito
backend

Direzione di ricerca

Examine DefaultRequestHandlerModel::get_fragment_pieces() where the buffer timestamp comparison causes false Delayed/Timing-out classifications for self-triggering TCs. Override the completeness check for TC/TA objects to determine if the found fragments already cover the requested time window instead of requiring a newer buffer entry. The fix is complete when these TCs no longer show kIncomplete/kRequestWindowAfterBuffer status during data-taking runs.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement
Description

Some pictures to help with explanation:

Current state of trigger buffers for a common data-taking mode (using low rate random trigger):
Image

Unpacking the data:
Image

Description:
For a low-rate, self-triggering TC (e.g. Random, CTB), the dataflow request to read back its own TC-buffer entry is, by default, built from that same object's own time range. DefaultRequestHandlerModel::get_fragment_pieces() only reports kFound if the buffer's newest entry is timestamped strictly after the requested window's end. For an object reading back itself, both sides of that comparison come from the same object — so the comparison is unwinnable by construction. Every such request is classified Delayed, then Timing-out once retries exhaust (def-tc-handler-2), throughout the run.

Looking at the data, TC fragments and objects are actually present and complete — n_inputs==0 is expected for these TC types (no TPG->TAG chain) — despite being tagged kIncomplete/kRequestWindowAfterBuffer. This isn't specific to Random TCs: Hardware_Signal fragments show the identical pattern, for the same structural reason.

Potential impact radius

???

Reason for change

Dashboards/alerting built on these counters are currently unusable for these sources — they show permanent failure regardless of actual system health, so real problems in these sources can't be distinguished from this expected-by-construction behavior.

Suggested implementations
  • Override the request-handler's completeness check for TC(/TA) (the base classes are virtual and already overridden for TPs) to be object-aware: "does what we found already cover the requested window" instead of "is there something newer in the buffer." Fixes the single-source, no-merging case; doesn't generalize to multi-TC-source/merged-decision configs.
  • Per-source watermarking: each source publishes its own "processed up to T" marker independently. Avoids the single-point-of-failure/cross-source-delay problem that broke the earlier in-stream heartbeat/zipper attempt in trigger, since there's no shared ordering/merge point.
Image
  • Other options (using time sync, override the readout request 'to take all that is available without retries' for this case, ...)
Testing suggestions

No response

Anything else?

No response

Lingua principale
C++
Stelle
0
Fork
8
Merge medio
3h 50m
PR unite (30g)
1

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DUNE-DAQ/trigger

Tutte le issue di DUNE-DAQ/trigger

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.