Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Interrupting ctrace leaves the running tool and its run directory behind

Aperta
  • Qualcosa non va?
#188 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
50/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cpp
Ambito
backend, cli

Direzione di ricerca

Start with the process spawning in include/Process/UnixProcess.hpp around lines 68-77, where the tool gets its own process group, and with the RunDirectory cleanup. Then find where POST /shutdown drains server mode so the signal path can reuse it. Done means that after Ctrl+C or SIGTERM no tool process or run directory remains, the exit codes are 130 and 143, and an integration test with a hung fake tool checks both.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug severity/major

Interrupting ctrace while an external tool runs stops ctrace but not the tool: the tool keeps running, orphaned, and the run directory stays in the temporary directory.

Observed

main eba7f88, macOS 15.6.1. A fake cppcheck that sleeps 600 s is first in PATH; ctrace --input ok.c --invoke cppcheck is interrupted after 2 s:

Signal Sent to ctrace Tool process Run directory
SIGINT (Ctrl+C) the process group exits 130 within 1 s still running left behind
SIGTERM the process group exits 143 at once still running left behind
SIGINT ctrace only exits 130 within 1 s still running left behind
SIGTERM ctrace only exits 143 at once still running left behind

Each interrupted run leaves one ctrace-cppcheck-* directory in $TMPDIR. A server stopped with SIGINT or SIGTERM also exits at once, without the drain that POST /shutdown performs.

Cause

  • ctrace installs no signal handler: SIGINT and SIGTERM take their default action, so no destructor runs (RunDirectory is not removed).
  • With a timeout, which every external tool has by default, the tool is started in its own process group (include/Process/UnixProcess.hpp:68-77), so the terminal's Ctrl+C does not reach it, and nothing kills it when ctrace dies.

Fix

On SIGINT and SIGTERM, stop the running tools (SIGTERM to their process group, then SIGKILL after a grace period), let the run directories be removed, and exit with 128 + the signal. In server mode, start the same drain as POST /shutdown.

Acceptance

  • After Ctrl+C or SIGTERM during a run, no tool process and no run directory remain.
  • The exit code is 130 for SIGINT and 143 for SIGTERM.
  • An integration test interrupts a run with a hung fake tool and checks both.

Found by the resilience campaign (docs/quality/resilience.md, scenarios C31 to C34, S18, S21).

Lingua principale
C++
Stelle
5
Fork
4
Merge medio
1h 9m
PR unite (30g)
81

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di CoreTrace/coretrace

Tutte le issue di CoreTrace/coretrace

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.