Targeting: a stored ruleset the reader cannot parse raises, failing the bulk flags call and the SDK ruleset for every flag

Aperta
  • Qualcosa non va?
#1,674 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
backend

Direzione di ricerca

Start in backend/app/core/targeting_adapter.py at normalise_targeting_rules, where the documented never-raises contract is broken for exceptions other than TargetingRulesError. Reproduce with a stored geo_within_radius whose radius is a very large integer (OverflowError) and a semver value like "1.²" (ValueError), then trace how get_user_flags, build_ruleset and segment membership call it. Done when one bad stored ruleset yields error for only its own flag while the bulk call and ruleset document still succeed, with tests covering both exception types.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug post-launch

Problem

normalise_targeting_rules (backend/app/core/targeting_adapter.py) documents that invalid content never raises, but a stored ruleset whose reading raises an exception other than the ones it catches escapes it. Measured at 3a6eb775 (with #1664's branch on top, which touches no targeting code): a stored dashboard geo_within_radius whose radius is a 401-digit integer makes normalise_targeting_rules raise OverflowError. The principal engineer's review of the #1666/#1669/#1672 plan measured the same with a ValueError (a stored dashboard semver value "1.²", which a save refuses).

What a reader then does with one such stored flag, measured in that review:

  • get_user_flags and build_ruleset raise, so the bulk flags call and the SDK ruleset document fail for every flag, not only this one;
  • segment membership raises (it catches only TargetingRulesError);
  • every evaluation of the flag answers error and writes an error-log row, which the safety monitor counts.

No API route can write such a row (saves refuse or, until #1672 is fixed, answer 500 without writing); it takes a direct database write or a row stored before validation existed.

Expected

A stored ruleset that cannot be read affects only its own flag, experiment or segment. The fix is a read-path decision: catching the exception broadly in normalise_targeting_rules makes the flag fall back to its global rollout (fails open, as returning None does today for the cases it catches), so the likely shape is a per-flag catch that answers error for that flag and lets the bulk call and the ruleset document go on. The docstring's promise is made true either way.

Lingua principale
Python
Stelle
0
Fork
4
Merge medio
5h 36m
PR unite (30g)
509

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Controlvar/controlvar

Tutte le issue di Controlvar/controlvar

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.