Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[Bug] RelayCommand Source Generator Fails Silently for Methods Starting With ‘On'

Aperta
  • Qualcosa non va?
#1,215 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
68/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
csharp
Ambito
tooling

Direzione di ricerca

Start with the RelayCommand source generator and the name-handling path for methods beginning with On. Reproduce the issue using the provided TestViewModel and binding, then compare the generated property name with the documented behavior. Done means OnPointerPressed generates PointerPressedCommand and the Avalonia binding compiles.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug :bug:
Describe the bug

Methods annotated with [RelayCommand] whose names start with On fail to generate command properties.

The documentation states that:

The name of the generated command will be created based on the method name. The generator will use the method name and append "Command" at the end, and it will strip the "On" prefix, if present. Additionally, for asynchronous methods, the "Async" suffix is also stripped before "Command" is appeneded.

However, the actual behaviour I am experiencing contradicts this claim.

Regression

No response

Steps to reproduce

Prerequisites:

  • .NET 10
  • C# 13
  1. Create a new Avalonia (Ver. 12.1.3) desktop project. Your project file should include:
<TargetFramework>net10.0</TargetFramework>
<RuntimeIdentifier>win-x64</RuntimeIdentifier>

  1. Add the CommunityToolkit.Mvvm (Ver. 8.4.2) NuGet package.

  2. Create a ViewModel with [RelayCommand] methods starting with On.

using CommunityToolkit.Mvvm.ComponentModel;
using CommunityToolkit.Mvvm.Input;
using System.Diagnostics;

namespace MyTestApp.Avalonia.ViewModels;

public partial class TestViewModel : ObservableObject

(etc.)

	[RelayCommand]
	private void OnPointerPressed()
	{
		Debug.WriteLine("Pointer pressed.");
	}

	[RelayCommand]
	private void AsdfPointerPressed()
	{
		Debug.WriteLine("Pointer pressed.");
	}
  1. Create a TestView. Attempt to bind to OnPointerPressedCommand.
<Window
	x:Class="MyTestApp.Avalonia.Views.TestView"
	xmlns="https://github.com/avaloniaui"
	xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
	xmlns:vm="using:MyTestApp.Avalonia.ViewModels"
	Name="TestView"
	x:DataType="vm:TestViewModel">

    <!-- This binding will fail to compile. -->
    <Button Command="{Binding OnPointerPressedCommand}" />

    <!-- This binding will compile successfully. -->
    <Button Command="{Binding AsdfPointerPressedCommand}" />

</Window>
Expected behavior

In the ViewModel, [RelayCommand] private void OnPointerPressed() { } would generate a PointerPressedCommand property, which the View could then execute.

Screenshots

No response

IDE and version

VS 2022

IDE version

18.10.2

Nuget packages
  • CommunityToolkit.Common
  • CommunityToolkit.Diagnostics
  • CommunityToolkit.HighPerformance
  • CommunityToolkit.Mvvm (aka MVVM Toolkit)
Nuget package version(s)

8.4.2

Additional context

No response

Help us help you

No, just wanted to report this

Lingua principale
C#
Stelle
3.8k
Fork
401
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di CommunityToolkit/dotnet

Tutte le issue di CommunityToolkit/dotnet

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.