[INFRA]: Sign GitHub release APKs with a stable key

Aperta
  • Qualcosa non va?
#243 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
android, dart, flutter, github-actions
Ambito
release, security

Direzione di ricerca

Read .github/workflows/android-release.yaml at the “Set up release signing” step and mobile/android/app/build.gradle.kts at signingConfigs. The issue says this requires maintainer access to repository secrets, so a first-time contributor cannot complete the setup independently. Done means the release uses the stable keystore without the debug-key warning and the release notes explain the one-time reinstall.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: infra chore

Context

The release workflow signs APKs with four secrets: ANDROID_KEYSTORE_BASE64, ANDROID_KEYSTORE_PASSWORD, ANDROID_KEY_ALIAS and ANDROID_KEY_PASSWORD. None of them is set on this repository, so every GitHub release so far was signed with a throwaway debug key. The v0.3.2 run logged:

ANDROID_KEYSTORE_BASE64 is not set; APKs are signed with a throwaway debug key and can't update each other.

Anyone who installs from GitHub Releases can't update to the next release in place: Android rejects it (INSTALL_FAILED_UPDATE_INCOMPATIBLE) and they have to uninstall, which deletes their local messages and keys. F-Droid builds are not affected (F-Droid signs them itself).

What to do

  • Create a release keystore and keep a backup somewhere safe (losing it means the same problem again).
  • Add the four repository secrets (ANDROID_KEYSTORE_BASE64 is the keystore file, base64-encoded).
  • Check that the next release run has no "throwaway debug key" warning.
  • Say in the release notes that people who installed an earlier GitHub APK need to reinstall once.

Where to look

.github/workflows/android-release.yaml (step "Set up release signing"), mobile/android/app/build.gradle.kts (signingConfigs).

Good to know

Only a maintainer can do this, since it needs repository secrets. Ideally before tagging v0.3.3.

Lingua principale
Dart
Stelle
9
Fork
5
Merge medio
49m
PR unite (30g)
34

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di CommandLineCoding/Elephant

Tutte le issue di CommandLineCoding/Elephant

Issue simili

Altre issue su Dart

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.