UI→API conversion sends LOAD_3D viewport_state as "" where the frontend sends the viewport camera

Aperta
  • Qualcosa non va?
#1,126 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
53/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
cli

Direzione di ricerca

Start with convert_ui_to_api and trace how it serializes the LOAD_3D viewport_state widget; compare the result with the frontend’s graphToPrompt output described in the issue. Check the bundled templates 3d_pixal3d_multi_views and 3d_pixal3d_trellis2_image_to_model, then verify that conversion preserves the viewport state needed by execute_save_3d_advanced in comfy_extras/nodes_save_3d.py. Done means the converted prompt provides the expected camera information, including for downstream wiring.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

UI→API conversion sends viewport_state as the saved "", while the frontend's graphToPrompt sends the live 3D viewport state (camera, model info). Found by converting the bundled 3D templates with convert_ui_to_api (the comfy run --workflow path) and comparing each prompt with the frontend's app.graphToPrompt().output for the same graph.

Versions: comfy-cli 54732c6 (main), ComfyUI v0.44.2 on CPU, comfyui-frontend-package 1.57.6, comfyui-workflow-templates 0.11.103.

Where: Preview3DAdvanced and Save3DAdvanced (input viewport_state, type LOAD_3D, required). Templates 3d_pixal3d_multi_views (nodes 246, 323, 372) and 3d_pixal3d_trellis2_image_to_model (nodes 246, 322, 323). The saved node has widgets_values: ["", 1024, 1024].

  • comfy-cli: "viewport_state": ""
  • frontend: "viewport_state": {"image": "", "mask": "", "normal": "", "camera_info": {"position": {"x": 10, "y": 10, "z": 10.000000000000002}, "target": {"x": 0, "y": 0, "z": 0}, "zoom": 1, "cameraType": "perspective", ...}, "recording": "", "model_3d_info": []}

Effect: execute_save_3d_advanced (comfy_extras/nodes_save_3d.py) turns a non-dict viewport_state into {}, so the node's camera_info output, and the camera in its Saved3DModels UI result, are None instead of the viewport camera. In these two templates nothing is wired to those outputs, so the generated model is unaffected; a graph that wires camera_info downstream would get None.

The frontend builds this value at serialisation time from the live viewport rather than from widgets_values, so matching it exactly may need a default camera on the converter side, or the server treating "" as "default camera". Related: #893 (widget types without a slot), #1077 (converter convergence).

Lingua principale
Python
Stelle
1k
Fork
176
Merge medio
1g 11h
PR unite (30g)
87

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Comfy-Org/comfy-cli

Tutte le issue di Comfy-Org/comfy-cli

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.