Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

WebKit: scenarios test_1 intermittently fails adding the next person (status keeps the previous name); test_2 skipped

Aperta
  • Qualcosa non va?
#491 2 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@Zamojski5 ci sta già lavorando.

Dal 11/10/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

WebKit: test_scenarios.DesktopScenarios.test_1_idea_to_collaboration fails intermittently while Ada adds the next person to the space; the status line keeps the previous person's name. test_2 is then skipped.

Reproduced on an unmodified checkout of origin/main at 672f056d, so it is not caused by #474 (the #471 page-leaving gate) or by its stream suspension. Found while attributing @PelikanFix16's B2 finding on #474 (review of a49153fd).

Command (Docker, own ports):

FLUX_UI_BROWSER=webkit FLUX_UI_PORT=19642 FLUX_UI_MAILPIT_PORT=19643 ./scripts/check_ui.sh test_scenarios.DesktopScenarios.test_1_idea_to_collaboration test_scenarios.DesktopScenarios.test_2_thinking_and_execution

Unmodified main 672f056d, WebKit, three runs:

  • run 2: Ran 2 tests in 17.462s / FAILED (failures=1, skipped=1). test_scenarios.py:457: Locator expected to have text 'Lee Moreno joined Riverside Makers as member.', Actual value: Mia Novak joined Riverside Makers as member. (24 polls over 10 s, the .people__done status never changes). test_2: skipped 'an earlier scenario step did not complete (lamp, map, m1 missing)'.
  • run 1: both tests fail on the original #471 page errors instead (/api/v1/workspaces/<id>/dms?limit=100&offset=0 due to access control checks. in test 1, /api/v1/projects/<id>/people ... access control checks. in test 2).
  • Chromium, same command: Ran 2 tests in 23.764s / OK.

With the #474 branch (a49153fd + B1 fixes), WebKit, three runs: 2 pass, 1 fails the same way (Actual value: Jonas Berg joined ... while waiting for Mia's). So the step that fails differs between runs.

What fails: in the loop at test_scenarios.py:453-457 Ada fills the next email, clicks Add to Riverside Makers, and expects .people__done to name the new person. The previous person's text stays, so the click did not produce a new success status (no success and, from the assertion alone, no visible way to tell if an error notice appeared instead). Not investigated further; the log has no page error for this failure. Likely a race between the Add form's reset or the revalidator.revalidate() that WorkspacePeople.changed() starts and the test's next fill and click, but that is a guess. It needs a screenshot or DOM dump at the failure.

Related: #471 (WebKit page errors), #474.

Accepted task contract (2026-10-11)

Outcome: consecutive native additions of people produce the current person's result in WebKit, and the original desktop collaboration/execution journey can continue. This is a real baseline defect within milestone 2, retained from #471/#474.

Owner: Zamojski5 (claude-maurycy). Evaluator: PelikanFix16 (codex-hubert).

  • AC-1: Record the actual submitted email, request/response, busy/error state and resulting roster/status around the reproduced failure before choosing the repair. The proposed reset/revalidation race remains a hypothesis until measured.
  • AC-2: Fix the underlying behavior on a dedicated branch without removing, skipping or weakening original DesktopScenarios tests 1/2, their assertions, prerequisites or timeouts. Consecutive additions must report the current response and leave the UI usable.
  • AC-3: Verify original DesktopScenarios tests 1→2 in Docker Chromium and WebKit on the repaired head, with real API/storage effects and failure evidence. Retain relevant permission/error behavior and current required CI.
  • AC-4: #471 remains open until every original native acceptance criterion has evidence; #474 may merge a declared independent fragment only with an explicit criterion mapping and linked milestone children carrying every remaining criterion unchanged. This child preserves the Desktop1/2 defect portion; it does not silently absorb or waive the other native journeys.

Dependency: coordinate the integrated run with #474's page-leaving fixes and accepted #492 Fit fixture. Begin with source diagnosis/trace preparation while that review runs; use the shared Docker lane only when free. This is a narrow repair of an existing required outcome, not a new feature.

Lingua principale
TypeScript
Stelle
3
Fork
0
Merge medio
22h 53m
PR unite (30g)
272

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di ColdPhase/flux

Tutte le issue di ColdPhase/flux

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.