Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Image parser uses a data: placeholder from data-src as the image URL, so the real src misses srcset enhancement

Aperta
  • Qualcosa non va?
#1,186 2 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@selul ci sta già lavorando.

Dal 20/10/2026.

Valutazione

Difficoltà
4/5
Tempo stimato
1-2 giorni
Idoneità per principianti
56/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
php, wordpress
Ambito
backend

Direzione di ricerca

Start with Optml_Manager::parse_images_from_html() in inc/manager.php and trace how its selected URL reaches Optml_Tag_Replacer::process_image_tags() and add_missing_srcset_attributes(). Reproduce the two attribute orders from the issue in PHPUnit, using profiler data keyed to the real src and reported data-opt-id; check the replacer and lazy-load suites plus integrations using possible_src_attributes(). Done when the real image URL drives per-tag processing and the data: placeholder order receives the expected srcset and sizes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug bug-report

Summary

When an image has a lazy-load attribute that holds a data: placeholder before its real src, the image parser takes the placeholder as the image's URL. The tag replacer then works on that placeholder instead of the real image, so the image never gets the page profiler's missing-srcset / sizes entries.

<img data-src="data:image/gif;base64,R0lGODlhAQABAIAAAP///////yH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" src="https://example.com/wp-content/uploads/2026/10/photo.jpg" alt="Test" />

The same image with src first, or without the data-src, is enhanced normally.

Found by the QA agent while testing #1184 / #1185. It also happens on development, so it isn't caused by #1185.

What happens

  1. Optml_Manager::parse_images_from_html() (inc/manager.php) matches the first src or possible_src_attributes() attribute it finds and returns its value as img_url. Here that's data-src, so img_url is data:image/gif.
  2. Optml_Tag_Replacer::process_image_tags() goes ahead with that URL: can_replace_tag( 'data:image/gif' ) returns true.
  3. The "optimized" URL for data:image/gif is the placeholder itself, so add_missing_srcset_attributes() builds every candidate from it. esc_url() turns each one into an empty string, and nothing is added.
  4. The real src is still moved to the CDN by the later URL replacement pass. Only the tag-level work is done against the wrong URL.

The image also gets data-opt-id computed from the placeholder URL (get_id_by_url( 'data:image/gif' )) instead of the real image. So every image with that placeholder shares one profiler ID.

Reproduction

PHPUnit, with profiler data seeded for the image (keyed by the real src ID and by the data-opt-id the browser profiler reports, assets/js/modules/srcset-detector.js:139):

Tag shape development #1185
data-src="data:…" before src not enhanced not enhanced
src before data-src="data:…" enhanced enhanced
no data-src enhanced enhanced

Impact

  • Images whose markup puts a lazy-load data: placeholder attribute before src miss the profiler's responsive srcset / sizes.
  • Other per-tag work that uses img_url (crop and dimension handling, profiler IDs, possibly lazy-load decisions) runs against the placeholder. This needs checking.

Possible fix

When picking an image's URL, skip attributes whose value is a data: URI, so a real src is used. This changes what parse_images_from_html() returns, which feeds every image replacement. It needs its own tests across the replacer and lazy-load suites, and a check against possible_src_attributes() integrations.

Lingua principale
PHP
Stelle
74
Fork
14
Merge medio
2g 9h
PR unite (30g)
22

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Codeinwp/optimole-wp

Tutte le issue di Codeinwp/optimole-wp

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.