Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Primary menu dropdown arrows gain circular button decoration in Neve 4.2.13

Aperta Adatta ai principianti
  • Qualcosa non va?
#4,636 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
84/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
php, scss, wordpress
Ambito
accessibility, frontend

Direzione di ricerca

Inizia da inc/views/nav_walker.php e dalle regole di navigazione in assets/scss/components/elements/navigation/_nav-menu.scss, quindi segui gli stili generici dei pulsanti in _buttons.scss e _extends.scss. Confronta Neve 4.2.12 e 4.2.13 con impostazioni personalizzate per il raggio e l’ombra dei pulsanti. Esegui e2e-tests/specs/a11y-ready/submenu-keyboard.spec.ts e verifica il comportamento su desktop, mobile-sidebar, RTL, focus e hover, senza decorazioni circolari del caret.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug-report bug-report-triage customer report regression

Summary

After updating to Neve 4.2.13, dropdown-arrow controls in the primary navigation can appear inside unwanted circles. The controls are expected to retain their previous undecorated appearance, but global button radius and shadow styling is now visible around them. This creates a prominent header styling regression on affected sites.

Customer context

  • Product / area: Neve theme, primary navigation dropdown controls
  • Version: Reported immediately after the latest update; repository history identifies 4.2.13 as the relevant release boundary
  • Environment: Windows 10 desktop; Firefox version unavailable
  • Integration / third party: Not provided
  • Reported error / symptom: Circular decoration around menu dropdown arrows
  • Impact: Visible header/navigation regression; an Additional CSS workaround was provided

Reproduction notes

Reported workflow:

  1. Update Neve to the most recent release, identified from repository history as 4.2.13.
  2. View a primary navigation menu containing child items.
  3. Observe circular decoration around the dropdown-arrow controls.

Repository comparison confirms the relevant markup and style-cascade change, but the customer's exact radius/shadow settings were not provided and the visual result was not reproduced in a browser during triage. A 4.2.12 versus 4.2.13 comparison with customized global button radius/shadow settings is the most direct verification.

Diagnosis

Conclusion

Neve 4.2.13 changed desktop primary-navigation caret controls from div[role="button"] elements to native button elements. Neve's generic button styling applies configurable border radius and shadow to every native button, while the navigation-specific reset leaves those two properties intact. This directly permits the reported circular decoration and establishes a regression from 4.2.12.

Where this likely occurs
  • inc/views/nav_walker.php — Nav_Walker::add_caret() lines 111–140 renders primary-navigation child-item carets as native buttons with caret-wrap; commit dd7ace85e484711bb32378a02b15cccf3d6a0c6e introduced this markup in 4.2.13.
  • assets/scss/components/elements/form-elements/_buttons.scss — generic button rule lines 27–40 extends the primary button styles for all native buttons.
  • assets/scss/components/main/_extends.scss — %nv-button-primary lines 10–29 supplies border-radius: var(--primarybtnborderradius, 3px) and box-shadow: var(--primarybtnshadow, none).
  • assets/scss/components/elements/navigation/_nav-menu.scss — .nav-ul button.caret-wrap lines 128–149 resets background, border, padding, color, and font but does not reset border radius or shadow.
  • Tag comparison confirms 4.2.12 renders the desktop caret as a div, while 4.2.13 renders it as a button. The generic button stylesheet is unchanged across those tags.
Engineering notes

The affected control is limited by the inspected render path to primary-navigation items with children. The markup change was part of an accessibility improvement, so the visual behavior intersects with native button semantics, keyboard interaction, focus visibility, desktop/sidebar variants, and customizable global button styles. The customer's exact button radius and shadow values are unavailable, but the staff-provided CSS workaround targets the two properties left active by the source cascade. Open issue #4425 was read and covers broader menu accessibility requirements, not this styling regression.

Test coverage status

e2e-tests/specs/a11y-ready/submenu-keyboard.spec.ts lines 16–203 covers desktop submenu semantics and keyboard interaction, with mobile coverage at lines 206–247. No caret-specific visual, border-radius, or box-shadow assertion was found during inspection.

What to verify or explore next
  • Reproduce with Neve 4.2.13 using a primary menu containing child items and non-default global button radius or shadow settings.
  • Compare computed caret styles and screenshots between 4.2.12 and 4.2.13.
  • Verify desktop, mobile-sidebar, RTL, keyboard-focus, and hover states.
  • Run npx playwright test e2e-tests/specs/a11y-ready/submenu-keyboard.spec.ts to confirm the interaction behavior alongside the visual check.
Unknowns / follow-up

The ticket does not provide the site's exact global button settings, CSS customizations, cache state, or a screenshot. Runtime reproduction was not performed during repository inspection.

Confidence

Confidence: 96/100

Neve 4.2.13 contains a verified release-boundary change that exposes primary-navigation caret controls to global button radius and shadow styles; the prior release used a non-button element, and no open issue was found for the resulting visual regression.

Source: HelpScout #3462897018
Generated by bug-report-triage (ID: bug-report-triage_6ab69a9fa67d16.12641093)

Lingua principale
PHP
Stelle
307
Fork
88
Merge medio
1g 6h
PR unite (30g)
10

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Codeinwp/neve

Tutte le issue di Codeinwp/neve

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.