client-v2: serializePrimitiveData rejects or silently corrupts String values for UInt64, UUID, Date and DateTime
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 82/100
Direzione di ricerca
Inizia in client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/SerializerUtils.java, in serializePrimitiveData, e segui i percorsi helper per UInt64, UUID, data e data-ora. Verifica il comportamento di conversione esistente e il controllo dell'intervallo di unsigned long correlato in BinaryStreamUtils. Il lavoro è completato quando i valori String vengono gestiti in modo coerente per questi tipi, i valori UInt64 non validi generano un errore invece di effettuare un wrapping silenzioso e i percorsi signed o numerici esistenti rimangono invariati.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
SerializerUtils.serializePrimitiveData accepts String input for most scalar column types via the convertToInteger / convertToLong / convertToBigInteger / convertToBigDecimal / convertToString helpers, but a subset of types either reject a String outright or — for UInt64 — silently corrupt it. This makes String coercion inconsistent across the type switch.
Line references are against 0.9.5, file client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/SerializerUtils.java.
Behaviour today
| Column type | String input | Result |
|---|---|---|
Int8/16/32, UInt8/16, Int64, UInt32 |
convertToInteger / convertToLong |
works |
Int128/256, UInt128/256 |
convertToBigInteger |
works |
Decimal* |
convertToBigDecimal |
works |
String, FixedString |
convertToString |
works |
UInt64 (:522) |
convertToLong → Long.parseLong (:760) |
throws above 2^63-1; silently wraps a negative |
UUID (:575) |
(UUID) value |
ClassCastException |
Date, Date32 (:553, :556) |
writeDate / writeDate32 (:1105) |
IllegalArgumentException: Cannot convert … to Long |
DateTime, DateTime64 (:559, :563) |
writeDateTime / writeDateTime64 (:1141) |
same |
The UInt64 case is a silent-corruption bug
convertToLong("-1") // -> -1L (Long.parseLong, signed)
writeUnsignedInt64(-1L) // -> writeInt64 -> FF FF FF FF FF FF FF FF
ClickHouse reads that back as 18446744073709551615. So a negative String is written as the maximum UInt64 with no error.
This is already inconsistent within the library: BinaryStreamUtils.writeUnsignedInt64(OutputStream, BigInteger) range-checks via ClickHouseChecker.between(value, TYPE_BIG_INTEGER, BigInteger.ZERO, U_INT64_MAX), so a BigInteger of -1 is correctly rejected. Only the String path wraps.
Values in [2^63, 2^64-1] are legal UInt64 values and are encodable on the wire (writeUnsignedInt64(long) just emits the raw 8 bytes), but unreachable through the String path.
Proposed fix
UInt64— use an unsigned-aware conversion at:522rather than changing the sharedconvertToLong, whichInt64(:504) andUInt32(:519) also use and which needs signed parsing:
/** UInt64 runs past Long.MAX_VALUE; the returned long carries the raw bit pattern. */
public static Long convertToUnsignedLong(Object value) {
if (value instanceof String) {
return Long.parseUnsignedLong((String) value);
}
return convertToLong(value);
}
UUID— add aStringbranch usingUUID.fromString.Date/Date32/DateTime/DateTime64— add aStringbranch in thewriteDate/writeDate32/writeDateTime/writeDateTime64helpers, which already dispatch onLocalDate/ZonedDateTime/OffsetDateTime/Timestamp. Fixing them there also covers their other callers.
Backward compatibility
Items 2 and 3 are purely additive: those inputs throw today, so nothing that currently succeeds changes behaviour.
Item 1 has one deliberate behaviour change: "-1" into a UInt64 column currently writes 18446744073709551615 and would now throw NumberFormatException. That replaces silent corruption with a loud error and aligns the String path with the existing BigInteger overload. Suggest keeping it as its own commit so it can be reviewed separately from the additive branches.
The Long / Number path stays permissive and passes raw bits through unchanged — callers legitimately supply the bit pattern for values above 2^63.
Why it matters
Reported from the ClickHouse Flink connector. Its checkpoint state format serialises map keys as strings, so for a Map(K, V) column the key reaches serializeMapData (:478) → serializePrimitiveData as a String. The connector currently has to reject Map(UInt64, …), Map(UUID, …), Map(Date, …), Map(Date32, …) and Map(DateTime(64), …) at planning time and tell users to change their table DDL, even though all of these are legal ClickHouse map key types.
More generally, any caller passing a String value for one of these types — nested or top-level — hits the same behaviour.
- Lingua principale
- Java
- Stelle
- 1.6k
- Fork
- 637
- Merge medio
- 2g 16h
- PR unite (30g)
- 30
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di ClickHouse/clickhouse-java
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 85/100
ClickHouse/clickhouse-java#3111 ·
-
area:data-type bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
ClickHouse/clickhouse-java#3098 · 1 commento ·
-
bug client-api-v2 test
Difficoltà 2/5 1-3 ore Idoneità per principianti 92/100
ClickHouse/clickhouse-java#3076 ·
-
area:sql-parser bug client-v1
Difficoltà 1/5 1-3 ore Idoneità per principianti 92/100
ClickHouse/clickhouse-java#3066 ·
-
area:general bug client-api-v2 jdbc jdbc-v2
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
ClickHouse/clickhouse-java#3063 ·
Tutte le issue di ClickHouse/clickhouse-java
Issue simili
-
executions.Query — startDate and timeRange filters are sent with inverted comparison operators Apertaarea/plugin
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
kestra-io/plugin-kestra#190 ·
-
litertlm-android AAR ships no consumer ProGuard rules → "mid == null" SIGABRT in minified apps Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
google-ai-edge/LiteRT-LM#3739 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
integra-team-red/meet-map#249 ·
-
[Studio][Bug] Cancelled create-user dialog keeps the password and admin switch for the next attempt Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
apache/rocketmq-dashboard#5064 ·
-
Consent portal: creating a duplicate Purpose shows a generic error instead of "already exists" Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
wso2/dpdp-accelerator#287 ·