[Bug]: Flatpak page shows flathub/stable for an app installed from flathub-beta (PrusaSlicer: 2.9.7 offered, 3.0.0 installed)

Aperta Adatta ai principianti
#144 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cpp, linux
Ambito
desktop

Direzione di ricerca

Inizia da src/flatpakclient.cpp in preferred() (righe 49-56), che ordina le voci del catalogo privilegiando flathub e poi stable. Verifica come toItem() unisce la voce di catalogo scelta con il ref installato, e dove viene costruito installedRefs, perché la correzione proposta dipende da questo. È completato quando un ref beta installato mostra il proprio remote e il proprio branch, e le app non installate continuano a preferire flathub/stable. Conferma prima con il maintainer il comportamento atteso (far corrispondere il ref installato oppure elencarli entrambi).

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

The Flatpak page offers the wrong copy of an app when the installed copy comes from a different remote or branch than the one the catalogue dedupe prefers. PrusaSlicer is installed from flathub-beta / branch beta, version 3.0.0, but the page shows flathub / branch stable, version 2.9.7 as the app's version, with "installed from flathub-beta".

Environment

  • CachyOS rolling, KDE Plasma 6.8.3 / KWin Wayland
  • cachyos-packageinstaller 2.0.0-1
  • flatpak 1.18.4
  • Remotes: flathub (system), flathub-beta (system), flathub (user)

Steps to reproduce

  1. flatpak install flathub-beta com.prusa3d.PrusaSlicer (installs branch beta, version 3.0.0)
  2. Open the Package Installer, go to the Flatpak page, search for PrusaSlicer.
  3. The page reports 2.9.7 as the available version and the installed version as 3.0.0.

What the system reports

$ flatpak list --app --columns=application,branch,installation,origin,version
com.prusa3d.PrusaSlicer    beta    system    flathub-beta    3.0.0

$ flatpak remote-ls --system flathub --app --columns=application,branch,version
com.prusa3d.PrusaSlicer    stable    2.9.7

$ flatpak remote-ls --system flathub-beta --app --columns=application,branch,version
com.prusa3d.PrusaSlicer    beta      3.0.0

Cause

src/flatpakclient.cpp, preferred() (lines 49-56):

/// Which of two offers of the same app is shown: Flathub before other remotes, the stable
/// branch before others, then by name so the choice never depends on the order of loading.
bool preferred(const FlatpakApp& a, const FlatpakApp& b) {
    const auto rank = [](const FlatpakApp& app) {
        return std::tuple(app.remote != "flathub"_L1, app.branch != "stable"_L1, app.remote, app.branch);
    };
    return rank(a) < rank(b);
}

The catalogue of every system remote is loaded and deduplicated per app id with preferred(), so the flathub/stable entry always wins — even when the installed ref is on another remote and branch. toItem() then mixes that entry with the installed copy: title and available version come from flathub/stable (2.9.7), while installedVersion, installedFrom and branch come from the installed beta copy.

The same ranking ignores the user installation, which is fine for the catalogue (the README says only system catalogs are read) but means an installed beta ref has no way to win.

Expected

When an app is installed, the offer should be the catalogue entry that matches the installed ref (same remote and branch) — or, if the catalogues disagree, both should be listed. Only uninstalled apps should fall back to "flathub, then stable".

Suggested fix

Rank by whether the ref is installed before the flathub/stable heuristics:

const auto rank = [&](const FlatpakApp& app) {
    const bool isInstalled = std::ranges::any_of(installedRefs, [&](const auto& ref) { return ref == app.ref; });
    return std::tuple(!isInstalled, app.remote != "flathub"_L1, app.branch != "stable"_L1, app.remote, app.branch);
};

Impact

The version shown for such an app is wrong, and the install/update action on that page targets the stable copy instead of the one the user is tracking. Updates themselves come from flatpak remote-ls --updates, so the update list is not affected — only the app offer and its displayed version.

Lingua principale
C++
Stelle
43
Fork
39
Merge medio
1g 6h
PR unite (30g)
12

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di CachyOS/packageinstaller

Tutte le issue di CachyOS/packageinstaller

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.