ci: make the security scans required to merge

Aperta
#303 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@ffumero2003 ci sta già lavorando.

Dal 8/11/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

ci

Context

govulncheck, zizmor and CodeQL run on PRs, but only ci-summary is a required check (.github/branch-protection-main.json), and ci-summary depends on checks/lint/test/b2keys/crosscompile — not the scans. So a red scan does not block a merge.

Note

The hosted branch-protection settings could not be read via API (404); confirm the current state before changing.

Acceptance criteria

  • R1. A PR with a failing scan cannot be merged.
  • R2. The handling of an org-wide advisory block is written down.

In scope

Make the three scan results required. Preferred: mark the govulncheck, zizmor and CodeQL job contexts as required in branch protection (a hosted setting; no workflow change). Alternative: add them to ci-summary's needs. Document how a newly published advisory (even in Go itself) that blocks every open PR is handled.

Out of scope

  • Unrelated work outside the components and behavior described in In scope.

Verification

  • Inspect the current hosted protection before changing it: gh api repos/Backblaze/blazer/branches/main/protection. This requires sufficient repository permissions; the original 404 limitation remains to be resolved.
  • With an authorized controlled PR, demonstrate that a failing govulncheck, zizmor, or CodeQL result prevents merging; show the passing control and record the relevant required-check contexts.
  • Review the documented procedure for an advisory that blocks every PR.
  • Expected result: the acceptance criteria above hold. If a check cannot run, report Could not run because: ...; if it starts but fails, report Could not complete because: .... A skipped check is not a pass.

Links

Lingua principale
Go
Stelle
66
Fork
18
Merge medio
1g 10h
PR unite (30g)
132

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Backblaze/blazer

Tutte le issue di Backblaze/blazer

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.