[Bug] Interactive auth callback hangs forever when an idle connection reaches AuthCodeReceiver first
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 48/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- python
- Ambito
- authentication, backend
Direzione di ricerca
Start by reading AuthCodeReceiver and its use of HttpServer; the issue identifies synchronous request handling and a connection accepted before the OAuth POST as the suspected path. Reproduce the flow with an idle connection reaching the listener first, then check that the real OAuth POST is processed and az login completes. The issue does not name a test file.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Describe the bug
When I run az login in my VS code terminal (using the VS Code SSH extension to connect to my Linux VM), it either succeeds, or it hangs forever after I log in via the browser until I close the browser and cancel the command. If I retry a couple of times, sometimes 1 succeeds. (Sometimes I spam 10x and it'll work once - fairly annoying).
To Reproduce
Steps to reproduce the behavior:
- Use the VS Code SSH extension to connect to a Linux VM
- az login on the VM (not with device code, this is using interactive auth via the browser)
- Login using the browser
- Login either works fine, or hangs forever
Expected behavior
The normal flow, looking at the code-
- az cli asks MSAL to perform interactive auth
- MSAL creates a temp HTTP server on a port and registers a redirect URI
- az cli opens the entra login auth page in the browser
- after auth, entra should be returning an HTML form that the browser POSTs to the redirect URI
- VS Code remote SSH forwards the local connection to that port on the Linux machine
- MSAL reads the auth code from the POST and does the token exchange
TLDR: the local browser should POST to the localhost port on the VS code tunnel, then to the MSAL HTTP server, before returning the auth code to az cli.
What you see instead
- MSAL was listening on the redirect port, ex. 39397
- An idle TCP connection arrives from a different ephemeral source port (this could really be from anything, but I'm guessing it has to do with the VS code remote SSH behavior - I think it shouldn't matter, though).
- MSAL accepted that connection
- It was an empty connection - no requests arrive
- The real OAuth POST arrives from a different port
- The real OAuth POST sits in the server's request queue forever
Accepted idle connection:
127.0.0.1:39397 <-> 127.0.0.1:40890
Recv-Q: 0
Queued real callback:
127.0.0.1:39397 <-> 127.0.0.1:40902
Recv-Q: 3026
The MSAL Python version you are using
- Azure CLI: 2.89.0
- MSAL Python: 1.36.0
- Also present in MSAL Python 1.37.0 source
- Python: Azure CLI bundled Python 3.14
- OS: Ubuntu 22.04
- Client: VS Code Remote SSH with a Windows browser
Additional context
I think this is a race condition and if the OAuth connection reaches the listening port first, everything works fine.
A few things I noticed:
- AuthCodeReceiver is using HttpServer, which I think is singled threaded. I can't find the GitHub link, but looking at the handler in Python source it looks like we process the request synchronously and don't accept another connection until the handler is done
self._server.timeout = timeoutin AuthCodeReceiver is for accepting new requests, but this hang should be happening after the initial accept - we're just waiting for the request bytes
- Lingua principale
- Python
- Stelle
- 971
- Fork
- 223
- Merge medio
- 13h 48m
- PR unite (30g)
- 2
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di AzureAD/microsoft-authentication-library-for-python
-
needs attention untriaged
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
AzureAD/microsoft-authentication-library-for-python#973 · 1 commento ·
-
AzureSDK bug P1
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
-
http_client docstring does not say that timeout, verify and proxies only configure the default sessionForse già presa @HardMax71 l’ha presa 40 giorni fa. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 25/100
-
[Bug] The built-in retry never retries the token POST: HTTPAdapter(max_retries=1) keeps urllib3's default allowed_methodsForse già presa @HardMax71 l’ha presa 46 giorni fa. Apertabug untriaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 35/100
AzureAD/microsoft-authentication-library-for-python#957 · 3 commenti ·
-
public-client untriaged
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
Tutte le issue di AzureAD/microsoft-authentication-library-for-python
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
-
[Device Support Request] HOBEIAN ZG-204ZL (Tuya PIR motion sensor with illuminance)Forse già presa @lenucksi l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
zigpy/zha-device-handlers#5493 ·
I maintainer di solito rispondono entro 3 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
drevendev/BeautifulRepo#42 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
writerslogic/holographic-memory#93 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
antoine-tena/kiln#47 ·
I maintainer di solito rispondono entro 1 giorno