[Feature Request] Update Managed Identity Exceptions to MSALServiceExceptions
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 25/100
- Tipo di issue
- Refactoring
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Ferma
- Stack tecnologico
- python
- Ambito
- authentication
Direzione di ricerca
Read the issue’s linked MSAL .NET pull request and the referenced MsalException property bag and MsalServiceExceptionFactory implementation to understand the intended exception mapping. Then inspect the Python managed identity exception code and tests; the issue asks for MSALServiceExceptions when managed identity reaches GA, so confirm that release context before defining completion.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
MSAL client type
Confidential
Problem Statement
In MSAL .NET, ManagedIdentityException only derived from ServiceException and not from UIRequiredException. This created a disconnect in our hierarchy of exceptions, as it didn't encompass all the necessary types that our application deals with, particularly in scenarios requiring user interaction (CAE with SLC). By moving to MsalServiceException, we ensure that all exceptions fit neatly into our established hierarchy, making it more predictable and easier to manage.
The introduction of ManagedIdentityException was initially intended to add extra data about the source leading to this exception. However, this approach led to a fragmentation in our exception handling logic. In scenarios involving shared logic between Managed Service Identity (MSI) and Security Token Service (STS), the code needed to handle or throw the correct exception type, leading to unnecessary complexity (SLC). By standardizing on MsalServiceException, we eliminate this fragmentation, allowing for more streamlined and reusable exception handling code.
The previous approach often required catching MsalServiceException and rethrowing it as ManagedIdentityException in certain contexts. This added an extra layer of complexity to our exception handling logic. With this refactor, we eliminate such patterns, simplifying the flow and making the code more maintainable.
MSAL .NET PR : https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/pull/4476
Proposed solution
To expose the Managed Identity source, we instead added a property bag with extra details for this exception. And create MSALServiceExceptions for MI Exceptions
The ask for MSAL Python is to use MSALServiceExceptions when you GA MI as a feature.
- Lingua principale
- Python
- Stelle
- 971
- Fork
- 223
- Merge medio
- 13h 48m
- PR unite (30g)
- 2
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di AzureAD/microsoft-authentication-library-for-python
-
needs attention untriaged
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
AzureAD/microsoft-authentication-library-for-python#973 · 1 commento ·
-
AzureSDK bug P1
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
-
http_client docstring does not say that timeout, verify and proxies only configure the default sessionForse già presa @HardMax71 l’ha presa 41 giorni fa. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 25/100
-
[Bug] The built-in retry never retries the token POST: HTTPAdapter(max_retries=1) keeps urllib3's default allowed_methodsForse già presa @HardMax71 l’ha presa 47 giorni fa. Apertabug untriaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 35/100
AzureAD/microsoft-authentication-library-for-python#957 · 3 commenti ·
-
public-client untriaged
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
Tutte le issue di AzureAD/microsoft-authentication-library-for-python
Issue simili
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 80/100
521xueweihan/HelloGitHub#4063 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
Vanilla-OS/apx-gui#112 ·
-
Devstral and Voxtral: section 5 fails in us-east-1 with 400 "Model does not support audio modality"Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
aws-samples/sample-per-model-bedrock#409 ·
I maintainer di solito rispondono entro 1 giorno
-
DuckDB 2.0 breaks to_pyarrow_batchesForse già presa @DG47 l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
ibis-project/ibis#12196 ·
I maintainer di solito rispondono entro 1 giorno