Forms: required checkbox and radio groups don't link their fieldset to the error message

Aperta Adatta ai principianti
  • Qualcosa non va?
#54,575 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
78/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
php, wordpress
Ambito
accessibility, frontend

Direzione di ricerca

Inizia da projects/packages/forms/src/contact-form/class-contact-form-field.php e confronta get_described_by() con il markup dei fieldset radio e checkbox intorno alle righe citate. Riproduci il problema con il modulo fornito con campi obbligatori, invialo vuoto e controlla se l’aria-describedby di ciascun fieldset punta al relativo messaggio di errore. Il lavoro è completato quando entrambi i gruppi espongono quella descrizione accessibile; l’issue non indica un file di test.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Bug Needs triage
Impacted plugin

Jetpack

Quick summary

When a required single input fails validation, it gets aria-describedby pointing at its error message. Required checkbox and radio groups don't: the fieldset gets aria-invalid="true", but nothing references the error message.

After clicking Submit on an empty form:

Field aria-invalid aria-describedby Accessible description in Chromium
Required text input true g4-yourname-text-error-message "This field is required."
Required field-checkbox-multiple fieldset true none empty
Required radio fieldset true none empty

The error messages exist, as g4-picksome-select-error-message and g4-pickone-radio-error-message. The individual checkbox and radio inputs don't reference them either. The visible error therefore isn't programmatically associated with its group (relevant to WCAG 1.3.1).

Single inputs get the link from get_described_by(), but the group fieldset tags don't use it (radio, checkbox). Adding it there looks like the fix, with type radio for radio groups and select for checkbox groups, but I haven't tried that change.

Steps to reproduce
  1. Add this form to a page, with Jetpack's Forms module active:
<!-- wp:jetpack/contact-form -->
<div class="wp-block-jetpack-contact-form">
<!-- wp:jetpack/field-text {"required":true} -->
<div class="wp-block-jetpack-field-text"><!-- wp:jetpack/label {"label":"Your name","required":true} /-->
<!-- wp:jetpack/input /--></div>
<!-- /wp:jetpack/field-text -->
<!-- wp:jetpack/field-checkbox-multiple {"required":true} -->
<div class="wp-block-jetpack-field-checkbox-multiple"><!-- wp:jetpack/label {"label":"Pick some","required":true} /-->
<!-- wp:jetpack/options -->
<ul class="wp-block-jetpack-options"><!-- wp:jetpack/option {"label":"Red"} /-->
<!-- wp:jetpack/option {"label":"Blue"} /--></ul>
<!-- /wp:jetpack/options --></div>
<!-- /wp:jetpack/field-checkbox-multiple -->
<!-- wp:jetpack/field-radio {"required":true} -->
<div class="wp-block-jetpack-field-radio"><!-- wp:jetpack/label {"label":"Pick one","required":true} /-->
<!-- wp:jetpack/options -->
<ul class="wp-block-jetpack-options"><!-- wp:jetpack/option {"label":"Yes"} /-->
<!-- wp:jetpack/option {"label":"No"} /--></ul>
<!-- /wp:jetpack/options --></div>
<!-- /wp:jetpack/field-radio -->
<!-- wp:jetpack/button {"element":"button","text":"Submit"} /-->
</div>
<!-- /wp:jetpack/contact-form -->
  1. View the page logged out and click Submit with everything empty.
  2. Inspect the text input and both fieldset elements.

Expected: each fieldset has aria-describedby pointing at its error message, as the text input does.

Actual: each fieldset has aria-invalid="true" and no aria-describedby.

Tested on

  • Jetpack 16.3.1 (Forms package 8.3.2) and 16.4 (Forms package 8.3.7), with the same result on both. The fieldset code looks the same on trunk, from reading the source only.
  • WordPress 7.1.4, PHP 8.3, Twenty Twenty-Five, only Jetpack active, on WordPress Playground in Jetpack offline mode.
  • Headless Chromium 156. Both inner-block field markup and attribute-style markup behave the same.

I checked Chromium's accessibility tree, not a real screen reader. I only ran the default form style. No console errors.

Site owner impact

Fewer than 20% of the total website/platform users

Severity

Moderate

What other impact(s) does this issue have?

No revenue impact

If a workaround is available, please outline it here.

Site code can add aria-describedby to the fieldset, pointing at the error message's ID.

Platform (Simple and/or Atomic)

Self-hosted

Lingua principale
PHP
Stelle
1.9k
Fork
906
Merge medio
1g 18h
PR unite (30g)
800

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Automattic/jetpack

Tutte le issue di Automattic/jetpack

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.