Mobile navigation trigger is dropped on single-capture routes

Chiusa
  • Qualcosa non va?
#4,630 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
php, wordpress
Ambito
frontend

Direzione di ricerca

Start by tracing how capture dialog trigger markers are preserved when a route is emitted as a single capture, then compare that path with the device variant route that retains its trigger. Check the same behavior when the header is extracted into a shared template part and add the requested contract test. Done means the phone width shows a working menu trigger, desktop hides it, and the captured menu remains accessible.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

On single-capture routes (one document per route), the mobile navigation trigger (hamburger button that opens the captured menu dialog) is dropped. The captured documents carry the dialog trigger markers (data-blocks-engine-capture-dialog-trigger, 5 per document), but the emitted pages, templates and parts contain none. At phone width the imported header shows only the site title, so the navigation can't be reached.

Observed

  • Desktop: the trigger is emitted as a 16x16 button that should be hidden; the source hides it (display:none).
  • Phone (390px): the trigger collapses to 0x0, while the source shows a 40x40 visible button.
  • A route that captured separate device variants keeps its trigger. The front page lost it once it became reflow-only (4 emitted triggers before, 2 after).
  • The emitted navigation uses overlayMenu:"never", so core's responsive overlay doesn't replace it either.

Acceptance

  • On a reflow-only/single-capture route, the phone-width header shows a visible menu trigger that opens the captured menu (or a core navigation overlay with equivalent items), and desktop hides it as the source does.
  • This also holds when the header is extracted into a shared template part.
  • Contract test with a single-capture header that hides the trigger at desktop and shows it under a max-width media query.

AI assistance: filed by Claude (Claude Code via Roadie) while investigating a site-builder capture import; findings verified against a private local fixture and rendered output.

Lingua principale
PHP
Stelle
25
Fork
3
Merge medio
2h 29m
PR unite (30g)
931

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Automattic/blocks-engine

Tutte le issue di Automattic/blocks-engine

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.