ClickHouseBackup CR provides no way to configure pod labels/attributes and other fields

Aperta
  • Qualcosa non va?
#2,141 1 commento 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

@Slach ci sta già lavorando.

Dal 5/11/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

The ClickHouseBackup CR does not provide any means to specify additional Job or Pod fields that may be required in commonplace deployments.

For example, in my environment I need to add a Pod label sidecar.istio.io/inject: "true" to get Istio sidecar injection on the backup Pod. Without this it is unable to communicate with the Istio-wrapped ClickHouse server, because Istio Envoy handles mTLS, authentication and request routing.

There appears to be no way to configure often-required fields such as:

  • labels and annotations on the Job itself and the Pods it creates
  • affinity and tolerations
  • resources such as CPU requests, memory requests and limits at container or pod level
  • securityContext fields including capabilities
  • Extra containers and initContainers on the Pod
  • Additional env and envFrom injection

Rather than adding all these individually, consider embedding a Job resource into the CR as a jobTemplate. Then merge your changes into it. Pod level changes are handled by the Job's pod template (embedded PodTemplateSpec).

An alternative might be to explicitly document that setting fields for such cross-cutting concerns is outside the operator's scope, and should be done with mutating webhooks. Test cover would be needed to ensure that this works reliably for a reasonable set of modified fields - and that the operator uses server-side apply + version digest annotations to manage reconcile.

Lingua principale
Go
Stelle
2.6k
Fork
588
Merge medio
4g 5h
PR unite (30g)
16

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Altinity/clickhouse-operator

Tutte le issue di Altinity/clickhouse-operator

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.