Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

internal/session: TestWorkNoWorkerCanDoStopsARunningWorkerAndLandsOnThePerson races a 30 s wall and fails beside another suite

Aperta
  • Qualcosa non va?
#1,339 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
78/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
go
Ambito
testing-qa

Direzione di ricerca

Start with TestWorkNoWorkerCanDoStopsARunningWorkerAndLandsOnThePerson and the eight time.After(30 * time.Second) sites in internal/session/task_divide_sketch_test.go. Run the focused session test beside the internal/tui3 suite with GOMAXPROCS=4 to reproduce the race, then inspect the held completer and worker-stop acknowledgement. Done means no fixed 30-second waits remain, waits respect owned synchronization or the test deadline, and the concurrent -count=5 run passes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:session area:tests bug sev:papercut

What happened

2026-09-21, dev@17ae56d34 plus the seven-plus-six commits of #1336 (which touch nothing in the task harness), running the repository's own gate on a laptop while a second full suite and a read-only reviewer were also running:

make pr-ready
…
--- FAIL: TestWorkNoWorkerCanDoStopsARunningWorkerAndLandsOnThePerson (37.55s)
    task_divide_sketch_test.go:594: the worker was never stopped for work only a person can do
FAIL
FAIL	github.com/Agent-Field/codeaf/internal/session	799.740s

The package took 800 s against the 210 s constrained-runner baseline in CLAUDE.md. CI's touched packages job on the same head passed. The same test on a quiet box:

go test -count=3 -run '^TestWorkNoWorkerCanDoStopsARunningWorkerAndLandsOnThePerson$' ./internal/session/
ok  	github.com/Agent-Field/codeaf/internal/session	0.879s

So it is the shape CLAUDE.md says is a bug report and not a known one: a session test that fails only when other suites run beside it.

Replication

Deterministic (no model). Run the session suite while another heavy suite runs beside it, on a box with a few cores:

GOMAXPROCS=4 go test -count=1 -timeout 15m ./internal/tui3/ &
GOMAXPROCS=4 go test -count=1 -timeout 15m -run 'TestWork' ./internal/session/

What a developer sees today, some of the time: the --- FAIL above after 30 s of waiting. On a quiet box it passes in well under a second.

Field (real models). Not applicable: this is a test's own wall, no product door.

Where

TestWorkNoWorkerCanDoStopsARunningWorkerAndLandsOnThePerson in internal/session/task_divide_sketch_test.go, and its siblings in the same file: each waits on a channel with case <-time.After(30 * time.Second) (search that string; eight sites). The worker being stopped is real work driven by a held completer (completer.hold); on a loaded box the stop lands after the thirty seconds have gone.

The fix

A test in this package should not lose a race against wall time. Either the wait is on a sync point the harness owns (the held completer's release, the worker's own stop acknowledgement) with no timer at all, or the ceiling is the test's deadline (t.Deadline() minus a margin) rather than a fixed thirty seconds. CLAUDE.md's learned preference already says it: deterministic clocks over real sleeps.

Acceptance

  • e2e: not applicable — nothing crosses a product door; the defect is the test's own timer.
  • Unit: every wait in task_divide_sketch_test.go is either a sync point with no timer or bounded by the test deadline; grep -c 'time.After(30' internal/session/task_divide_sketch_test.go is 0.
  • Unit: the test passes with -count=5 while go test ./internal/tui3/ runs beside it on a 4-core box.
  • No manual page or change entry is involved.
Lingua principale
Go
Stelle
115
Fork
14
Merge medio
9h 35m
PR unite (30g)
752

Preparare l'ambiente

Non abbiamo ancora controllato i file di configurazione di questo progetto. Parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Agent-Field/CodeAF

Tutte le issue di Agent-Field/CodeAF

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.