[BUG]: Non-team transcript submission trusts client-supplied opponent transcripts and emails, allowing rating forgery
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 58/100
Direzione di ricerca
Start with backend/controllers/transcript_controller.go:22-78, the request handler named in the regression plan, and trace how it resolves participants and persists transcripts and ratings. Check the existing controller tests and test setup for MongoDB and Redis. Done means submissions cannot choose an opponent or affect users who did not participate, with a regression test covering the reported scenario.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Bug Description
SubmitTranscripts accepts opponentRole, opponentEmail, opponentID and opponentTranscripts from the authenticated caller. For non-team rooms it stores them as the opponent's submission, judges the fabricated debate and calls UpdateRatings for both resolved users. No check proves either user participated in the room.
Steps to Reproduce
- Authenticate as an attacker.
- POST /submit-transcripts with any roomId, role 'for', attacker transcripts designed to win.
- Include opponentRole 'against', opponentEmail of the victim, and crafted losing opponentTranscripts.
- Repeat with new roomIds; each success stores transcripts, judges the debate and changes both users' Glicko ratings.
Logs and Screenshots
HTTP 200 with judge result; MongoDB gains debate_transcripts and debates rows and users.rating changes for the chosen opponent. Service has no room/participant lookup on this path.
Expected vs actual
- Expected: The system enforces the invariant described in the remediation below: Resolve both participants from server-side room/debate state, verify the caller belongs to the room and role, and never accept opponent transcripts from the client.
- Actual: Arbitrary Elo inflation/deflation for any user, forged debate history, corruption of real room transcripts, and abuse of AI quota.
Impact
Critical - Application is unusable
Arbitrary Elo inflation/deflation for any user, forged debate history, corruption of real room transcripts, and abuse of AI quota.
Recommended fix
Resolve both participants from server-side room/debate state, verify the caller belongs to the room and role, and never accept opponent transcripts from the client.
Regression test plan
- Add a test that exercises the path in
backend/controllers/transcript_controller.go:22-78and asserts that the defect is rejected or handled safely. - Reproduce the scenario above against a local backend with MongoDB and Redis; confirm the old behavior fails the assertion and the fixed behavior passes.
- Run
go test ./...,go vet ./...and, for WebSocket/concurrency fixes,go test -race ./....
Code of Conduct
- I have joined the Discord server and will post updates there
- I have searched existing issues to avoid duplicates
- Lingua principale
- TypeScript
- Stelle
- 108
- Fork
- 264
- Merge medio
- 6h 53m
- PR unite (30g)
- 8
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di AOSSIE-Org/DebateAI
-
[BUG]: Inverted Mic icon causes input confusion in Bot Debate RoomForse già presa @Rusky-1014 l’ha presa 5 giorni fa. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
AOSSIE-Org/DebateAI#802 ·
I maintainer di solito rispondono entro 1 giorno
-
[BUG]: Duplicate preposition in heading and unformatted feedback text on Strengthen Argument pageForse già presa @sujitkr268 l’ha presa 4 giorni fa. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
AOSSIE-Org/DebateAI#801 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
[BUG]: Singleton state leak in matchmaking tests causes non-deterministic failuresForse già presa @mithunkc017-ship-it l’ha presa 8 giorni fa. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
AOSSIE-Org/DebateAI#798 · 3 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
[BUG]: Live Debate Rooms page overflows horizontally on mobile screensForse di nuovo libera @SYED-IRTEZA-HUSSAIN-RIZVI l’ha presa 8 giorni fa e non c’è nessuna pull request aperta. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
AOSSIE-Org/DebateAI#797 · 4 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
[BUG]: Inconsistent branding on authentication page (Arguehub vs DebateAI)Forse di nuovo libera @SYED-IRTEZA-HUSSAIN-RIZVI l’ha presa 8 giorni fa e non c’è nessuna pull request aperta. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
AOSSIE-Org/DebateAI#784 · 4 commenti ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di AOSSIE-Org/DebateAI
Issue simili
-
documentation lens:human needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
thebristolsound/birdbrain#2246 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
A voting window past about 69.9 million hours stores a deadline that reads back as no deadlineApertabug ready-for-human
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
BoardGamesEmpire/board-games-empire-backend#1452 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
good first issue stretch
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
I maintainer di solito rispondono entro 1 giorno