ElasticPress menu item moved to the bottom of the Query Monitor menu with Query Monitor 4.1+

Aperta
#136 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
65/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript, php, wordpress

Direzione di ricerca

Start by tracing how this add-on registers its Query Monitor menu item and how Query Monitor 4.1+ combines add-on items with core items; the issue names the qm/output/menus PHP filter and assets/build/query-monitor.js as relevant entry points. Check how the menu ordering changed, then confirm ElasticPress appears near the top, ideally after Timeline, with Query Monitor 4.1 or later.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

type:bug
Describe the bug

With Query Monitor 4.1.0 or later, the ElasticPress item in the Query Monitor admin bar dropdown moved from near the top of the list to the very bottom. It now shows after all the core panels and the conditionals (e.g. is_single(), is_singular()).

Expected: ElasticPress appears near the top of the menu, as it did with Query Monitor 4.0.0 and earlier, ideally right after Timeline.
Actual: ElasticPress is the last item in the menu.

Cause: In Query Monitor 4.0.0, every panel (core and add-on) added its menu item through the qm/output/menus PHP filter at its own priority. Our QueryMonitorOutput uses the default priority 10, so it ended up near the top. Starting with Query Monitor 4.1.0, the core panels are registered and sorted in JavaScript. Items coming from qm/output/menus are appended after them ({ ...coreItems, ...QueryMonitorData.menu.sub } in assets/build/query-monitor.js), so filter priority no longer has any effect. This affects every Query Monitor add-on, not just this plugin.

Steps to Reproduce
  1. Install and activate ElasticPress, Debug Bar ElasticPress, and Query Monitor 4.1.0 or later.
  2. Visit any front-end page while logged in as an administrator.
  3. Hover the Query Monitor item in the admin bar.
  4. ElasticPress is at the bottom of the dropdown.
  5. Downgrade to Query Monitor 4.0.0 and repeat: ElasticPress is near the top.
Screenshots, screen recording, code snippet
image
Environment information
  • Query Monitor: 4.1.1 (issue introduced in 4.1.0; not present in 4.0.0)
  • Debug Bar ElasticPress: 4.0.0 (develop)
WordPress information

No response

Code of Conduct
  • I agree to follow this project's Code of Conduct
Lingua principale
PHP
Stelle
28
Fork
16
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di 10up/debug-bar-elasticpress

Tutte le issue di 10up/debug-bar-elasticpress

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.