(RSLC) Missing `_FillValue` attribute on swath polarization datasets
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
Research direction
Start with the RSLC swath polarization datasets at /science/LSAR/RSLC/swaths/frequency[A|B]/[HH|HV|VH|VV], then compare their creation path with the complex-valued fill-value example in python/packages/nisar/workflows/h5_prep.py lines 74-87. Add the missing _FillValue attributes with dtypes matching their raster datasets, and verify that the XML and HDF5 attributes agree.
Written by the indexing model from the issue text.
Description
Location: /science/LSAR/RSLC/swaths/frequency[A|B]/[HH|HV|VH|VV]
Description: XML schema expects the _FillValue attribute that is missing from all polarization datasets in the RSLC swaths.
From QA Log (example for one pol):
Attributes found in XML but not HDF5: {'_FillValue', 'isReceiveOnly'} - Dataset /science/LSAR/RSLC/swaths/frequencyA/HH
Impact: Schema non-compliance. Tools relying on this attribute to identify invalid/fill pixels may fail or produce incorrect results.
Notes:
- As noted in https://github.com/isce-framework/isce3/issues/297, per CF Conventions the
_FillValuedtype should match exactly the dtype of the raster dataset it is attached to. (e.g. both complex64, both complex32, etc.)
If it helps, here is existing ISCE3 code which creates complex-valued fill value:
Issue originally opened Apr 6, 2023: https://github-fn.jpl.nasa.gov/isce-3/isce/issues/1302
cc: @hfattahi @bhawkins
- Dominant language
- Python
- Stars
- 240
- Forks
- 90
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 15
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from isce-framework/isce3
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
isce-framework/isce3#353 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
isce-framework/isce3#341 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
isce-framework/isce3#290 · 1 comment · 3 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
isce-framework/isce3#255 ·
Maintainers usually reply within 1 day
-
GCOV/GSLC: geocoded `referenceTerrainHeight` is entirely NaN because a 1-D LUT is misdetected as 2-DOpen
Difficulty 3/5 1-2 days Newbie friendliness 74/100
isce-framework/isce3#402 ·
Maintainers usually reply within 1 day
All issues in isce-framework/isce3
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
kornia/kornia#5263 · 1 comment ·
Maintainers usually reply within 1 day
-
approved correction metadata
Difficulty 1/5 Under an hour Newbie friendliness 88/100
acl-org/acl-anthology#10133 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
BasedHardware/omi#20084 ·
Maintainers usually reply within 1 day
-
bug needs-acceptance wg/evaluation-quality
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
vllm-project/semantic-router#4424 ·
Maintainers usually reply within 1 day