Update embedding examples

Open
#1,392 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
desktop, tooling

Research direction

Start by reading examples/embedding/internal_ipkernel.py and examples/embedding/ipkernel_qtapp.py, then compare their imports and connect calls with current ipykernel and qtpy usage. Update the examples to support the listed Qt bindings and current connect_qtconsole API, and verify that both examples run with the supported combinations.

Written by the indexing model from the issue text.

Description

The internal_ipkernel.py and ipkernel_qtapp.py are out of date. Some issues:

  • It is using PyQt4, which is very old, and not supported on some platforms (e.g. osx-arm64)
  • Explicit use of PyQt means it doesn't work with PySide. Should use qtpy so it will work with Pyside2/6 or PyQt5/6.
  • This line: from IPython.lib.kernel import connect_qtconsole fails on recent ipythons. I think the replacement is from ipykernel import connect_qtconsole. See https://github.com/ipython/ipython/issues/13610
  • The connect calls also would need to be updated (I think those are the old style signals).
Dominant language
Python
Stars
734
Forks
411
Avg merge
1d 2h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ipython/ipykernel

All issues in ipython/ipykernel

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.