SetLogLevel defaultLevel not protected by mutex on wildcard case

Open
#189 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
backend

Research direction

Start by reviewing pull request #188, which contains the proposed mutex protection and concurrency test. Run the test with the race detector to reproduce the previous failure; done means the wildcard case is race-free and the concurrency test passes.

Written by the indexing model from the issue text.

Description

need/triage

I opened this PR (https://github.com/ipfs/go-log/pull/188) with an extra mutex protection for defaultLevel on wildcard case.

Also added a concurrency test that fails with the previous version when running with -race flag.

This was observed after upgrading our dependencies.

Dominant language
Go
Stars
63
Forks
55
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ipfs/go-log

All issues in ipfs/go-log

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.