Provide Query Paramater to avoid copying Value's data?
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start with the datastore query API around NextSync(), Next(), and Process(), then review the linked go-libp2p-kad-dht issue for the copying concern. Clarify the parameter's behavior and error cases, especially forbidding Next() and Process() when it is enabled. Done means the query behavior and those invalid calls are covered by tests.
Written by the indexing model from the issue text.
Description
When NextSync() is used it is safe to avoid copying the Value's data. This will help mostly with go-ds-leveldb queries see https://github.com/libp2p/go-libp2p-kad-dht/issues/39.
@whyrusleeping Do you think this is a good idea? If this paramater is provided it will be an error to call either the Next() or Process() methods on the results.
- Dominant language
- Go
- Stars
- 248
- Forks
- 68
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ipfs/go-datastore
-
exp/novice help wanted kind/enhancement status/ready
Difficulty 5/5 Over a week Newbie friendliness 25/100
ipfs/go-datastore#160 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ipfs/go-datastore#139 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
ipfs/go-datastore#116 · 31 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 30/100
ipfs/go-datastore#102 · 5 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ipfs/go-datastore#101 · 4 comments · 1 reaction ·
All issues in ipfs/go-datastore
Similar issues
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
harvester/harvester#12311 · 1 comment ·
Maintainers usually reply within 1 day
-
verifyrun --bracket-digest --credit: relative --witness is could-not-check, absolute path creditsOpenbug effort:s impact:low raised-by:desk risk:low
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
medici-finance/assay#6580 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
blinklabs-io/gouroboros#3026 ·
Maintainers usually reply within 1 day