Add a Rename method?

Open
#100 3 comments 0 reactions 2 assignees View on GitHub

@schomatis is already working on this.

Since Oct 5, 2018.

Assessment

This issue has not been assessed yet.

Description

The migration of the blockstore to multihashs only is going to require a massive renaming off a large number of keys. At least for the flatfs datastore, an important optimization is to rename the file rather than remove and insert a new key. The last time we did such a rename (https://github.com/ipfs/fs-repo-migrations/pull/39) we only had a single datastore config using flatfs so we special cased it. Now things are more complicated with badgerds this will be more difficult.

Is it worth it to provide a Rename method?

Dominant language
Go
Stars
248
Forks
68
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ipfs/go-datastore

All issues in ipfs/go-datastore

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.