Most links in user interface are made with <div onClick=...> intead of <a href=...>
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- javascript, react
- Domain
- accessibility, frontend
Research direction
Start by locating the React UI components that render clickable navigation elements, then compare their use of useNavigate() with React Router’s Link. The issue names no files or tests, so first identify the affected links and check how they are exercised. Done means links use browser-recognizable anchors and right-clicking offers the correct link context menu.
Written by the indexing model from the issue text.
Description
Please verify that this bug has NOT been raised before.
- I checked and didn't find a similar issue
Describe the bug*
The new React user interface is amazing. However, there is one thing that is really annoying. Most links are made with a <div onClick=...> instead of a <a href=...>. This means that the browser can not distinguish between text and links and will show the wrong context menu on right click. There is no way to copy a link without first opening it.
InvenTree is using react-router. All links should be made with a <Link to=...> instead of the useNavigate() hook.
Steps to Reproduce
- Right click (almost) any link
- The browser will show the wrong context menu
Expected behaviour
The browser should display the correct context menu.
Deployment Method
Docker
Version Information
1.4.0
Try to reproduce on the demo site
I tried to reproduce
Is the bug reproducible on the demo site?
Reproducible
Relevant log output
- Dominant language
- Python
- Stars
- 7.7k
- Forks
- 1.6k
- Avg merge
- 21h 45m
- Merged PRs (30d)
- 204
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from inventree/InvenTree
-
enhancement triage:not-checked
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
inventree/InvenTree#13318 · 1 reaction ·
Maintainers usually reply within 1 day
-
enhancement User Interface wontfix
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
inventree/InvenTree#13292 · 5 comments ·
Maintainers usually reply within 1 day
-
[FR] Add spinner arrows in Quantity when adding a BOM itemMay be free again @Alonso-Lopez-1 claimed this 50 days ago, and no pull request is open. Openenhancement help wanted starter User Interface
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
inventree/InvenTree#12677 · 6 comments ·
Maintainers usually reply within 1 day
-
enhancement triage:not-checked
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
inventree/InvenTree#13317 · 1 reaction ·
Maintainers usually reply within 1 day
-
bug stock
Difficulty 3/5 1-2 days Newbie friendliness 40/100
inventree/InvenTree#13285 · 1 comment ·
Maintainers usually reply within 1 day
All issues in inventree/InvenTree
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ip-tools/patzilla#219 · 2 comments ·
Maintainers usually reply within 1 day
-
EPSSClient commits to its SQLite cache once per score: a 100-CVE bulk fetch makes 101 disk flushesOpenpriority:p3 technical-debt
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
jimmy058910/jmo-security-repo#1673 ·
Maintainers usually reply within 1 day
-
enhancement ready
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
integration: frontier_silicon
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
home-assistant/core#193176 · 2 comments ·
Maintainers usually reply within 1 day
-
task create and task update take --body-file and --stdinPossibly taken @JuanBarriosS claimed this today. Opencli enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
pyrite-wiki/pyrite#1687 · 1 comment ·
Maintainers usually reply within 1 day