Possible missing diagnostic with both `-fembed-offload-object` and `-foffload-include-binary` passed
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- cpp
Research direction
Start by reading the discussion linked from the issue and locate CodeGenModule::Release() in the repository. Determine whether -fembed-offload-object and -foffload-include-binary are intended to be mutually exclusive; then check the relevant option handling and tests for existing behavior. Done means adding a clear diagnostic if the options conflict, or updating the handling if they are compatible.
Written by the indexing model from the issue text.
Description
Describe the bug
We need to investigate if these options are intended to be mutually exclusive.
If so, we need to emit a clear diagnostic.
If not, we need to update the handling in CodeGenModule::Release()
Context: https://github.com/intel/llvm/pull/23388#discussion_r4353496285
To reproduce
No response
Environment
- OS: [e.g Windows/Linux]
- Target device and vendor: [e.g. Intel GPU]
- DPC++ version: [e.g. commit hash or output of
clang++ --version] - Dependencies version: [e.g. the output of
sycl-ls --verbose]
Additional context
No response
- Dominant language
- LLVM
- Stars
- 1.5k
- Forks
- 869
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 194
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from intel/llvm
-
bug hip
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
intel/llvm#23531 · 1 comment ·
Maintainers usually reply within 2 days
-
bug Coverity
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
bug Coverity
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 2 days
-
Coverity
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 2 days
-
confirmed
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
intel/llvm#23011 · 3 comments ·
Maintainers usually reply within 2 days