`automated` visibility tokenized but not handled crashes the scan
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
Research direction
Start with delphi-frontend/src/main/java/au/com/integradev/delphi/antlr/ast/node/VisibilityNodeImpl.java and the Visibility.java definition referenced in the issue. Run the provided Delphi example to reproduce the assertion, then verify that automated is recognized as a visibility and the scan completes without crashing.
Written by the indexing model from the issue text.
Description
Prerequisites
- This bug is in SonarDelphi, not SonarQube or my Delphi code.
- This bug has not already been reported.
SonarDelphi version
unrelevant
Delphi version
unrelevant
SonarQube version
unrelevant
Issue description
Analyzing a piece of code that uses the automated keywork the scanner crashes with the following error:
...
java.lang.AssertionError: Visibility node has unexpected token type: AUTOMATED
...
This error traces back to the fact that the automated keyword is tokenized but never actually parsed to the correct visibility, that also needs to be implemented.
Steps to reproduce
Analyze a piece of code that uses the automated keywork
Minimal Delphi code exhibiting the issue
interface
type
TTriggerAutomatedVisibility = class
automated
procedure Foo;
public
procedure Bar;
end;
implementation
procedure TTriggerAutomatedVisibility.Foo;
begin
end;
procedure TTriggerAutomatedVisibility.Bar;
begin
end;
end.
- Dominant language
- Java
- Stars
- 159
- Forks
- 33
- Avg merge
- 4d 17h
- Merged PRs (30d)
- 6
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from integrated-application-development/sonar-delphi
-
enhancement rule triage
Difficulty 3/5 1-2 days Newbie friendliness 65/100
-
engine enhancement
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
feature rule
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
feature rule
Difficulty 5/5 Over a week Newbie friendliness 35/100
integrated-application-development/sonar-delphi#423 · 1 comment ·
-
Support long directive names in the `{$IFOPT}` directiveMay be free again @jgardn3r claimed this 50 days ago, and no pull request is open. Openengine enhancement
integrated-application-development/sonar-delphi#412 · 1 comment · 1 reaction · 1 assignee ·
All issues in integrated-application-development/sonar-delphi
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
beehive-lab/TornadoVM#1151 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
FasterXML/jackson-dataformats-binary#823 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day