0.7.3 has breaking changes to 0.7.2

Open
#147 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start by comparing the 0.7.2 and 0.7.3 behavior around snappy_formats.DEFAULT_FORMAT and get_decompress_function, then review the unit tests that use snappy.StreamCompressor. The report does not define whether done means restoring compatibility, providing a migration path, or documenting the breaking change, so that outcome needs clarification.

Written by the indexing model from the issue text.

Description

Hello,
Seems like patch versions were used for backward incompatible changes.
Example:

I have the following function that works fine in 0.7.2:

def snappy_decompress_stream(in_file, out_file):
    decompress_func, read_chunk = snappy_formats.get_decompress_function(snappy_formats.DEFAULT_FORMAT, in_file)
    decompress_func(in_file, out_file, start_chunk=read_chunk)

The above function doesn't work in 0.7.3
There is no snappy_formats.DEFAULT_FORMAT anymore. Looking at the unit tests, it seems get_decompress_functionis not used and instead a snappy.StreamCompressor is introduced.

I'm a little confused about a patch breaking all the above!

Dominant language
Python
Stars
490
Forks
104
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from intake/python-snappy

All issues in intake/python-snappy

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.