image fill no longer fills screen in device portrait orientation after updating to 1.0.39.0

Open
#725 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
android, csharp, typescript
Domain
frontend

Research direction

Reproduce on web and Android in portrait with image fill enabled, then trace from the admin UI image-fill setting to the slideshow rendering component in the SvelteKit frontend and the corresponding Android view. Search for the image-fill handling that controls how the image scales, and compare against the previous release. Done means portrait orientation fills the screen on both targets and the existing UI tests still pass.

Written by the indexing model from the issue text.

Description

bug
Version

1.0.39.0

Deployment Method

Android 16, web

Description

Image fill no longer fills the screen on a device in portrait orientation after updating to 1.0.39.0.
This worked perfectly before the update.

Reproduction

Update to 1.0.39.0, use android or web version in a portrait orientation, toggle "image fill" to on in admin UI.

Expectations

No response

Configuration

Logs

Pre-Submission Checklist
  • This is a bug report and not a feature request

  • I have provided all of the required information to reproduce the bug (config, logs, etc.)

  • I have checked for related issues and checked the documentation

Dominant language
C#
Stars
2.4k
Forks
121
Avg merge
18d 20h
Merged PRs (30d)
1

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from immichFrame/ImmichFrame

All issues in immichFrame/ImmichFrame

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.