Feature: optional HOL Guard SecurityScanner backend for skill publish scans
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by reading the existing SecurityScanner contract, SkillScannerAdapter, and scanner documentation to understand how requests, health checks, and findings are represented. Then check how publish scans receive an unpacked package path and how scanner configuration is handled. Done means a local HOL Guard adapter maps findings and reports unavailable service errors explicitly, with benign and malicious fixtures plus adapter health and error tests.
Written by the indexing model from the issue text.
Description
Proposal
Add an optional HOL Guard-backed implementation of SkillHub's existing SecurityScanner interface for pre-trust skill/package scanning.
HOL Guard: https://github.com/hashgraph-online/hol-guard
Distribution/Agent Skill repo: https://github.com/hashgraph-online/hol-guard-plugin
Why this fits the current architecture
SkillHub already has the provider-neutral domain contract:
SecurityScanner.scan(SecurityScanRequest)isHealthy()getScannerType()
and currently maps the built-in scanner through SkillScannerAdapter. The published scanner docs also describe multiple analysis engines and a configurable scanner service URL.
A narrow integration could preserve that contract and add a HolGuardSecurityScannerAdapter that invokes HOL Guard locally against the unpacked skill/package path, then maps structured findings/severity into SkillHub's existing SecurityScanResponse / SecurityFinding model.
Intended boundary
- local scanning; Guard Cloud not required
- do not execute target install/lifecycle scripts merely to scan them
- preserve SkillHub's existing review/publish semantics
- fail explicitly if the configured scanner is unavailable rather than treating that as a clean result
- map prompt-injection, unsafe-command, secret/exfiltration, plugin/MCP, and supply-chain findings into the existing response model
- add malicious and benign
SKILL.md/plugin fixtures plus adapter health/error tests
This would be an additional backend, not a request to replace SkillHub's built-in scanner or its existing engines.
If this direction fits the project, we can contribute the smallest adapter/config/docs/tests PR against the existing SecurityScanner abstraction.
- Dominant language
- Java
- Stars
- 5.2k
- Forks
- 841
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 77
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from iflytek/skillhub
-
effort/l priority/p2 risk/high triage/deferred
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
iflytek/skillhub#1039 · 1 comment ·
Maintainers usually reply within 1 day
-
effort/l priority/p2 risk/high triage/deferred
Difficulty 3/5 1-2 days Newbie friendliness 57/100
iflytek/skillhub#1036 · 2 comments ·
Maintainers usually reply within 1 day
-
[Feature] 面向非技术用户的 skill 展示:中文展示名/简介/能力说明 + 首页推荐板块Possibly taken @XiaoSeS claimed this 1 day ago. Openeffort/l priority/p1 risk/high triage/core
iflytek/skillhub#1035 · 4 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
[Feature] RFC:默认关闭的厂商中立后端业务事件出口 / Opt-in backend business-event exportPossibly taken @xiaoyaner0201 claimed this 2 days ago. Openeffort/l priority/p1 risk/high triage/core
Difficulty 5/5 Over a week Newbie friendliness 25/100
iflytek/skillhub#1009 · 2 comments ·
Maintainers usually reply within 1 day
-
[Feature] DSH 技能中心扩展路线图:场景助手、技能使用与管理、项目复用及自动化Possibly taken @XiaoSeS claimed this 9 days ago. Openeffort/m enhancement priority/p2 triage/deferred
iflytek/skillhub#998 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
All issues in iflytek/skillhub
Similar issues
-
status: waiting-for-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
spring-projects/spring-framework#37614 ·
Maintainers usually reply within 1 day
-
azure-spring azure-spring-aad Client
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Azure/azure-sdk-for-java#51046 · 1 reaction ·
Maintainers usually reply within 1 day
-
helm-knative-apply.sh fails with Helm 4Possibly taken A pull request linked to this issue is open or already merged. Openarea: triage theme: undefined
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
jhipster/generator-jhipster#35895 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
oracle/graalvm-reachability-metadata#11659 ·
Maintainers usually reply within 1 day