Panic in processBroadcasts
@peterbroadhurst is already working on this.
Since Sep 1, 2021.
Assessment
This issue has not been assessed yet.
Description
FireFly e2e has been failing in the Github actions, and I just tried it locally… I found that ethconnect was failing with:
ethconnect_0_1 | [2021-09-01T21:18:51.134Z] DEBUG WS/d6949896-7c43-4e51-6483-dc37de68f424: Received: {Type:listenreplies Topic: Message:}
ethconnect_0_1 | panic: runtime error: index out of range [1] with length 1
ethconnect_0_1 |
ethconnect_0_1 | goroutine 26 [running]:
ethconnect_0_1 | github.com/kaleido-io/ethconnect/internal/ws.(*webSocketServer).processBroadcasts.func1(0xc000308000, 0x1, 0x1)
ethconnect_0_1 | /ethconnect/internal/ws/wsserver.go:170 +0x569
ethconnect_0_1 | github.com/kaleido-io/ethconnect/internal/ws.(*webSocketServer).processBroadcasts(0xc000146ff0)
ethconnect_0_1 | /ethconnect/internal/ws/wsserver.go:186 +0x1fd
ethconnect_0_1 | created by github.com/kaleido-io/ethconnect/internal/ws.NewWebSocketServer
ethconnect_0_1 | /ethconnect/internal/ws/wsserver.go:77 +0x165
Quick look at the code suggests it's a lack of synchronization on the s.topics between these lines, will investigate more:
https://github.com/hyperledger-labs/firefly-ethconnect/blob/2e28ec415a4c3098624d7898cc58ec43af7b5f4a/internal/ws/wsserver.go#L165-L166
- Dominant language
- Go
- Stars
- 76
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperledger-firefly/ethconnect
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
hyperledger-firefly/ethconnect#223 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
hyperledger-firefly/ethconnect#219 · 6 comments ·
-
error openapiOpen
Difficulty 3/5 1-2 days Newbie friendliness 15/100
hyperledger-firefly/ethconnect#203 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
hyperledger-firefly/ethconnect#202 · 6 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
All issues in hyperledger-firefly/ethconnect
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
grafana/tempo-operator#1691 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
hashicorp/terraform-mcp-server#583 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
backend bug low-priority
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
lognorman20/monaco#6225 ·