Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Intermittent test failure

Open
#136 0 comments 0 reactions 1 assignee View on GitHub

@EnriqueL8 is already working on this.

Since Apr 30, 2024.

Assessment

This issue has not been assessed yet.

Description

This is affecting build stability in the repo:

Tooks like buildTLSListener is being allowed to run on a routine and not being waited to complete before the end of a test.

?   	github.com/hyperledger/firefly-common/pkg/i18n/es	[no test files]
time="2024-03-13T23:29:54Z" level=error msg="Failed TLS DN check: Does not match CN =~ /^right\\.example\\.com$/"
time="2024-03-13T23:29:54Z" level=error msg="Failed TLS DN check: Nil cert chain"
time="2024-03-13T23:29:54Z" level=error msg="Failed TLS DN check: Empty cert chain 0"
PASS
panic: Log in goroutine after TestConnectSkipVerification has completed: read failed: EOF

goroutine 41 [running]:
testing.(*common).logDepth(0xc000244340, {0xc000014470, 0x10}, 0x3)
	/opt/hostedtoolcache/go/1.21.8/x64/src/testing/testing.go:1022 +0x4c5
testing.(*common).log(...)
	/opt/hostedtoolcache/go/1.21.8/x64/src/testing/testing.go:1004
testing.(*common).Logf(0xc000244340, {0x79eba9?, 0x1?}, {0xc000509fc0?, 0x0?, 0x538440?})
	/opt/hostedtoolcache/go/1.21.8/x64/src/testing/testing.go:1055 +0x54
github.com/hyperledger/firefly-common/pkg/fftls.buildTLSListener.func1()
	/home/runner/work/firefly-common/firefly-common/pkg/fftls/fftls_test.go:115 +0x5e
created by github.com/hyperledger/firefly-common/pkg/fftls.buildTLSListener in goroutine 40
	/home/runner/work/firefly-common/firefly-common/pkg/fftls/fftls_test.go:103 +0x111
Dominant language
Go
Stars
5
Forks
15
Avg merge
3d 9h
Merged PRs (30d)
3

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from hyperledger-firefly/common

All issues in hyperledger-firefly/common

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.