Intermittent test failure
@EnriqueL8 is already working on this.
Since Apr 30, 2024.
Assessment
This issue has not been assessed yet.
Description
This is affecting build stability in the repo:
Tooks like buildTLSListener is being allowed to run on a routine and not being waited to complete before the end of a test.
? github.com/hyperledger/firefly-common/pkg/i18n/es [no test files]
time="2024-03-13T23:29:54Z" level=error msg="Failed TLS DN check: Does not match CN =~ /^right\\.example\\.com$/"
time="2024-03-13T23:29:54Z" level=error msg="Failed TLS DN check: Nil cert chain"
time="2024-03-13T23:29:54Z" level=error msg="Failed TLS DN check: Empty cert chain 0"
PASS
panic: Log in goroutine after TestConnectSkipVerification has completed: read failed: EOF
goroutine 41 [running]:
testing.(*common).logDepth(0xc000244340, {0xc000014470, 0x10}, 0x3)
/opt/hostedtoolcache/go/1.21.8/x64/src/testing/testing.go:1022 +0x4c5
testing.(*common).log(...)
/opt/hostedtoolcache/go/1.21.8/x64/src/testing/testing.go:1004
testing.(*common).Logf(0xc000244340, {0x79eba9?, 0x1?}, {0xc000509fc0?, 0x0?, 0x538440?})
/opt/hostedtoolcache/go/1.21.8/x64/src/testing/testing.go:1055 +0x54
github.com/hyperledger/firefly-common/pkg/fftls.buildTLSListener.func1()
/home/runner/work/firefly-common/firefly-common/pkg/fftls/fftls_test.go:115 +0x5e
created by github.com/hyperledger/firefly-common/pkg/fftls.buildTLSListener in goroutine 40
/home/runner/work/firefly-common/firefly-common/pkg/fftls/fftls_test.go:103 +0x111
- Dominant language
- Go
- Stars
- 5
- Forks
- 15
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperledger-firefly/common
-
Difficulty 4/5 3-5 days Newbie friendliness 58/100
hyperledger-firefly/common#245 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
hyperledger-firefly/common#236 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
hyperledger-firefly/common#188 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
hyperledger-firefly/common#156 · 2 comments ·
-
Cache entries are not automatically reaped when they reach their TTLMay be free again @peterbroadhurst claimed this 1208 days ago, and no pull request is open. Open
hyperledger-firefly/common#85 · 1 assignee ·
All issues in hyperledger-firefly/common
Similar issues
-
Difficulty 2/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area/security kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
agent-substrate/substrate#2935 ·
Maintainers usually reply within 1 day
-
100 points complexity: trivial documentation drips-wave good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
automation models
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Guardian health server binds :8080 and collides with the Voltron proxyPossibly taken @denislemire claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
projectcalico/calico#14341 ·
Maintainers usually reply within 1 day