Adapters for AsyncRead and Stream?
Nobody has claimed this yet.
- #41 by @davidpdrsn — closed without merging
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- rust
- Domain
- backend-api-design
Research direction
Start by reading the adapter in tower-http/src/serve_file.rs around the referenced line, then compare its AsyncRead-to-Body behavior with the http-body API. Review the proposed Stream<Item = Bytes> and Stream<Item = Vec> alternatives and determine the intended upstream scope and completion criteria with maintainers.
Written by the indexing model from the issue text.
Description
In tower-http we have an adapter that makes an AsyncRead into a Body https://github.com/tower-rs/tower-http/blob/serve-file/tower-http/src/serve_file.rs#L107. Is that something you'd be interested in upstreaming to http-body? Might be useful for others.
Adapters for Stream<Item = Bytes> and Stream<Item = Vec<u8>> might also be nice.
If you're interested I can submit a PR.
- Dominant language
- Rust
- Stars
- 173
- Forks
- 71
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperium/http-body
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
Feature Proposal: Add `try_clone` method to `Body` traitPossibly taken @pearzl claimed this 380 days ago. Open
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
All issues in hyperium/http-body
Similar issues
-
An EXE started from the shell with MAXALLOC FFFFh leaves a 0-paragraph free block after its ownOpenbug low-priority
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
dividebysandwich/rust-dos#629 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
eliasstravik/herdr-projects#758 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
enhancement needs:sonnet ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
kinqsradio/orbyn-engineering#297 ·
Maintainers usually reply within 1 day