Creating a destination with an existing ID returns 400
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Start at the handler for POST /api/v1/tenants/:tenant_id/destinations and inspect its tests; compare its conflict handling with POST /publish. Check the release-note conventions because the issue says changing either status needs a release note. Done means duplicate destination IDs and destination-limit conflicts return 409, with tests and a release note covering the behavior.
Written by the indexing model from the issue text.
Description
POST /api/v1/tenants/:tenant_id/destinations with an id that a live destination already has returns:
{"status":400,"message":"destination already exists"}
409 Conflict is the usual status for this: the request is well-formed, and it conflicts with the current state. The API already uses 409 on POST /publish for a conflicting event id.
The same handler returns 400 when the tenant has reached its destination limit, which is also a state conflict more than a bad request.
Changing either status breaks clients that match on 400, so it needs a release note. For reference, PUT /tenants/:tenant_id has no such case: it is an upsert and returns 200 for an existing tenant, 201 for a new one.
- Dominant language
- Go
- Stars
- 1.1k
- Forks
- 70
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 56
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hookdeck/outpost
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 48/100
hookdeck/outpost#1117 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
All issues in hookdeck/outpost
Similar issues
-
Say in the changelog that the text-index update cannot be rolled backPossibly taken @praetorianer777 claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
praetorianer777/GoTome#275 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
SAP/crossplane-provider-btp#1118 ·
Maintainers usually reply within 1 day
-
benchmark: `make setup` fails because audit-exporter builds with Go 1.25.0 while go.mod requires 1.26.0Possibly taken @xsvm claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 84/100
volcano-sh/volcano#6097 · 1 comment ·
Maintainers usually reply within 1 day
-
area/infra backlog bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
praetorianer777/Stator#417 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day