fix(engine): emit hvc1 for streaming H.265 GPU outputs
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- audio-video-rtc, testing-qa
Research direction
Locate buildStreamingArgs() on current main and inspect the existing argument-construction tests. Verify how software, VideoToolbox, and supported GPU H.265 branches build their commands, then add coverage for H.265 and H.264 cases. Done means every H.265 path has exactly one hvc1 tag while H.264 and VP9 remain unchanged.
Written by the indexing model from the issue text.
Description
Summary
The streaming encoder adds the MP4 hvc1 sample-entry tag for software H.265, but GPU H.265 branches can omit it. Those outputs may use FFmpeg's default hev1 tag even though the encoded HEVC stream itself is valid.
This reduces compatibility with Apple playback software and other consumers that expect parameter sets through an hvc1 sample entry.
Root cause
In buildStreamingArgs(), the existing:
args.push("-tag:v", "hvc1");
is nested inside the software-encoder branch. The common codec === "h265" decision is outside that branch, so VideoToolbox and the other supported GPU H.265 encoders do not necessarily receive the same container tag.
Affected version
Observed in HyperFrames v0.8.114 (01c6f6004a00ecfa6e77ab4025b47a46a5e925fc). Please confirm against current main.
Expected behavior
Every MP4 streaming H.265 path should append -tag:v hvc1 exactly once, independently of whether the selected encoder is libx265, VideoToolbox, NVENC, VAAPI, QSV, or AMF. H.264 and VP9 paths must remain unchanged.
Proposed change
Move the H.265 sample-entry decision after software/GPU encoder selection but keep it inside the common H.265 branch:
if (codec === "h265") {
args.push("-tag:v", "hvc1");
}
Validation
Add argument-construction tests covering:
- software H.265;
- HDR VideoToolbox H.265;
- each supported GPU H.265 encoder;
- software and GPU H.264 negative cases;
- exactly one
hvc1tag per H.265 command.
The change is container metadata only and does not alter encoded picture data, bitrate, transfer characteristics, or HDR metadata.
- Dominant language
- TypeScript
- Stars
- 54.1k
- Forks
- 4.9k
- Avg merge
- 7h 41m
- Merged PRs (30d)
- 729
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from heygen-com/hyperframes
-
bug difficulty/easy help wanted triage/ready
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
heygen-com/hyperframes#5393 · 1 comment ·
Maintainers usually reply within 1 day
-
difficulty/easy enhancement help wanted triage/ready
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
heygen-com/hyperframes#5388 ·
Maintainers usually reply within 1 day
-
difficulty/easy enhancement help wanted triage/ready
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
heygen-com/hyperframes#5387 ·
Maintainers usually reply within 1 day
-
difficulty/easy documentation help wanted triage/ready
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
heygen-com/hyperframes#5386 ·
Maintainers usually reply within 1 day
-
gcp-cloud-run image pins Chrome 148, which drops `background-clip: text` glyphs inside layered children; the CLI's Chrome 152 paints themPossibly taken @user-github-me claimed this 1 day ago. Openbug difficulty/medium triage/ready
Difficulty 1/5 Under an hour Newbie friendliness 84/100
heygen-com/hyperframes#5117 ·
Maintainers usually reply within 1 day
All issues in heygen-com/hyperframes
Similar issues
-
area: desktop area: website priority: P2 type: feature
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
appandflow/stim#3411 · 1 comment ·
Maintainers usually reply within 1 day
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
rjsf-team/react-jsonschema-form#5485 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 65/100
lingdojo/kana-dojo#32090 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
Friction: Org home and org switcher copy still say repositories and connected agents live in the personal accountPossibly taken A pull request linked to this issue is open or already merged. Openfriction
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
kentcdodds/kody#3265 ·
Maintainers usually reply within 1 day