hil: allow openocd_esp under CI once a retained session survives job-end cleanup
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Read hil_test.py's config check and the provider's ci_refusal() logic, then inspect how hand_off launches the cleanup holder. First decide whether retained openocd_esp sessions may outlive a CI job; if so, verify on the rig that both the server and cleanup holder survive job-end cleanup. Done means lifting both refusals and rostering an openocd_esp board on ci.lan.
Written by the indexing model from the issue text.
Description
Deferred from hathach/tinyusb#4255.
The openocd_esp flasher is refused under a CI job, when RUNNER_TRACKING_ID or GITHUB_ACTIONS is set, through agentrc's ci_refusal(). The reason: when a session times out, its openocd server and the board's cleanup holder are meant to outlive the run. actions/runner's job-end cleanup kills every process carrying the job's RUNNER_TRACKING_ID (v2.337.0 JobExtension.cs:802-845), so a retained session would not survive the job.
Remaining work:
- Decide whether a retained openocd_esp session may outlive the CI job. If it may, show on the rig that the server and the cleanup holder survive job-end cleanup, for example by launching outside the job's tracking, as
hand_offdoes for the holder. - Then lift the refusal in
hil_test.py's config check and in the provider, and roster anopenocd_espboard on ci.lan.
Why deferred: no ci.lan board uses openocd_esp today, and it needs a policy decision plus rig evidence. Found in the stage 7 T2 review.
- Dominant language
- C
- Stars
- 7.2k
- Forks
- 1.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 97
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hathach/tinyusb
-
followup Prio 📌
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
followup Prio 📌
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
test_audio_host: out-of-bounds read in test_audio_host_uses_exponential_full_speed_iso_intervalOpenfollowup Prio 📌
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
followup Prio 📌
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
followup Prio 📌
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 90/100
Lakr233/vphone-cli#743 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
libsdl-org/SDL#16584 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
FriendsofECCE/ECCE#519 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
containers/crun#2415 ·
Maintainers usually reply within 1 day