`haddock-autolink` submodule: Licensing, inclusion
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 18/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- git, haskell
- Domain
- build-system, tooling
Research direction
Start with the containers/.gitmodules entry for docs/_extensions/haddock-autolink and inspect the referenced repository at the pinned revision. Review its licensing and hosting relationship to containers and ghc, then seek a maintainer decision on whether licensing or dependency ownership needs to change; done requires an agreed resolution for the issue's two concerns.
Written by the indexing model from the issue text.
Description
While cloning the main ghc repository (using git clone https://gitlab.haskell.org/ghc/ghc.git --recurse-submodules) I noticed that the containers repository was being cloned. That's OK because the containers library is a submodule of the ghc repo.
However, I noticed that the haddock-autolink submodule of containers is also being cloned. This is because haddock-autolink is a submodule of the containers repo.
[submodule "containers/docs/_extensions/haddock-autolink"]
path = containers/docs/_extensions/haddock-autolink
url = https://github.com/m-renaud/haddock-autolink
( https://github.com/haskell/containers/blob/b216597c83755131aac0f335744e2f803eaa9399/.gitmodules )
Here is what I noticed:
- The linked submodule https://github.com/m-renaud/haddock-autolink does not have a LICENSE (or equivalent) of any sort. Should
containersrequire a license given thatghcusescontainerswhich in turn useshaddock-autolink? - All the submodules of ghc look to be hosted at https://gitlab.haskell.org/ghc/ .
haddock-autolinkseems to be a notable exception. Might it be a good idea to incorporate this submodule into thecontainersrepo itself? (especially because it is a small one). Ideally all the source dependencies of ghc should be more firmly in its control so we don't need to worry about the long term availability/maintenance of thehaddock-autolinkrepo which is under control of a different entity than ghc presumably.
Request maintainers of containers suggest if any of these two issues need to be addressed.
cc: @m-renaud
- Dominant language
- Haskell
- Stars
- 355
- Forks
- 194
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 6
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from haskell/containers
-
major-release strictness Tree
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
haskell/containers#1260 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
haskell/containers#1261 · 9 comments ·
-
IntSet low-hanging-fruit performance
Difficulty 3/5 1-2 days Newbie friendliness 58/100
haskell/containers#1251 ·
-
maintainability major-release
Difficulty 3/5 1-2 days Newbie friendliness 70/100
haskell/containers#1250 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 50/100
haskell/containers#1242 ·
All issues in haskell/containers
Similar issues
-
bug good-title pdd
Difficulty 2/5 Under an hour Newbie friendliness 82/100
objectionary/phino#1630 ·
Maintainers usually reply within 1 day