add support for strict_type connections
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
Research direction
Start by tracing how the node Meta.strict_type setting reaches connections and how SQLAlchemyConnectionField constructs sorting when the node type is NonNull. Reproduce the nullable edge-list behavior and constructor failure described in the issue. Done means node metadata can set strict_type on the connection and the field constructor handles the NonNull node correctly.
Written by the indexing model from the issue text.
Description
Currently the strict_type=True option on the Meta class for a node is ignored and the connections end up having nullable values in the edge list. If you override the connection_class to set the strict_type on the connection, the SQLAlchemyConnectionField constructor fails because it does not unwrap the NonNull from the node before trying to set up the sort.
Ideally it should be possible to set the strict_type option on the connection via metadata on the node class.
- Dominant language
- Python
- Stars
- 985
- Forks
- 224
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from graphql-python/graphene-sqlalchemy
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
graphql-python/graphene-sqlalchemy#422 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
graphql-python/graphene-sqlalchemy#419 · 3 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
graphql-python/graphene-sqlalchemy#418 · 2 comments · 2 reactions ·
All issues in graphql-python/graphene-sqlalchemy
Similar issues
-
essnmx good first issue
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
[Feature] 奇物选择添加优先级 Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
syfoud/Simulated_Scepter#174 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Giskard-AI/giskard-oss#2840 · 1 comment ·
-
A claim comment carrying the issue number is silently declined while the workflow reports success Openarea: repo bug perceived difficulty: 2
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
yeti-platform/yeti#1380 ·