SAP vendor no longer resolves: Foojay renamed "SAP Machine" to "SapMachine"

Open Beginner friendly
#231 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
kotlin
Domain
tooling

Research direction

Start with distributions.kt and the failing tests in FoojayApiTest.kt:129. Check how Foojay's api_parameter or synonyms can be used instead of the display name for vendor matching. Done when the Java 8, 11, and 16 vendor resolution tests pass.

Written by the indexing model from the issue text.

Description

bug

Foojay renamed the SAP distribution from SAP Machine to SapMachine. distributions.kt still maps JvmVendorSpec.SAP to "SAP Machine", so a toolchain request for vendor SAP no longer matches any distribution.

The vendor specific implementation does not influence vendor resolution tests fail for Java 8, 11 and 16 (FoojayApiTest.kt:129), e.g. in https://github.com/gradle/foojay-toolchains/actions/runs/33383581175/job/99461104158. main has been red since 2026-08-31.

Fix: match on Foojay's api_parameter (sap_machine) or synonyms rather than the display name, so future renames don't break resolution.

Dominant language
Kotlin
Stars
223
Forks
28
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from gradle/foojay-toolchains

All issues in gradle/foojay-toolchains

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.