Decouple shared editor history from SPX-specific state
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 12/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
This is design work, not a starter task. Begin with the existing shared-history implementation from PR #3494 and the SPX EditorState that owns the SPX-specific History, then the Tutorial v2 design docs on the issue-3403-tutorial-v2 branch. Done means a documented, SPX-independent history contract that a unified Course Editor timeline can use, with standalone SPX undo/redo unchanged and tests covering cross-domain undo/redo.
Written by the indexing model from the issue text.
Description
Parent
Part of #3403.
Long-term follow-up to the shared Course Editor history work discussed in PR #3494.
Background
The Course Editor contains both Course-owned files and an embedded SPX project. A single undo/redo timeline across both would make editing more coherent. The current SPX EditorState owns an SPX-specific History, so sharing one history with the Course Editor requires injecting it into the SPX Editor and coordinating state restoration.
The PR discussion identifies a longer-term direction: make History or EditorState independent of SPX so different editor domains can participate in shared editing history without making the generic history abstraction depend on the SPX project model. This is an architectural follow-up to the immediate shared-history implementation.
Scope
- Evaluate and define an SPX-independent editing-history or editor-state abstraction that can be shared by the Course Editor and embedded SPX Editor.
- Support a unified Course Editor undo/redo timeline spanning Course-owned files and embedded SPX project edits.
- Define how undo and redo restore each domain's state and how they interact with SPX Editor state updates.
- Preserve existing standalone SPX Editor history behavior and avoid introducing Course-specific concepts into the generic abstraction.
Plan
- Review the shared-history implementation and identify the remaining coupling to SPX
EditorState, project reloads, and mutation recording. - Design a generic history/state contract and document how independent editor domains register and restore changes.
- Refactor the history or editor-state ownership to use the SPX-independent contract.
- Integrate the Course Editor and embedded SPX Editor with one timeline and add focused coverage for cross-domain undo/redo and existing standalone behavior.
Acceptance criteria
- The shared history abstraction does not require SPX project or Course-specific types.
- Course Editor provides one chronological undo/redo timeline across Course-owned files and embedded SPX project edits.
- Undo and redo consistently restore the affected Course or project state without stale editor/runtime state.
- Standalone SPX Editor retains its existing undo/redo behavior.
- The abstraction and its integration contract are documented.
Design references
- PR #3494 discussion: SPX-independent History or EditorState
- PR #3494: Course Editor for Playground Courses
- Course Editor and preview issue #3420
- Tutorial v2 technical design
Development coordination
Follow the coordination requirements in #3403:
- Create the implementation branch from the latest
goplus/issue-3403-tutorial-v2and target that integration branch in the pull request until the initiative is integrated intodev. - Follow the User Tutorial v2 product design and the relevant contracts in the Tutorial v2 tech design.
- If this work changes a shared decision or module contract, update the corresponding design document in the same child PR rather than silently diverging from it.
- Dominant language
- TypeScript
- Stars
- 70
- Forks
- 59
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 50
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from goplus/builder
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Adjust the default aspect ratio and background color of course video dialogsPossibly taken @qingqing-ux claimed this today. Open
goplus/builder#3619 · 1 assignee ·
Maintainers usually reply within 1 day
-
Add a border around the entire Copilot dialogPossibly taken @qingqing-ux claimed this today. Open
goplus/builder#3618 · 1 assignee ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 75/100
siyuan-note/siyuan#20629 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Volume eject does not refuse system, root or /home mountsPossibly taken @bernardopg claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
spacedriveapp/spacedrive#3159 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
melgarafael/DeskcommCRM#3000 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
callstackincubator/simlock#639 ·
Maintainers usually reply within 1 day