Refuse to publish a theme kit no released server serves
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- github-actions, go
- Domain
- build-system, devops, release
Research direction
Start with the kit publish workflow, which currently checks only that the astro@ tag matches the package version, and with internal/themehost/kit.go, where the kit versions a server lists are defined. Use the existing make bump-kit target and its test as the model for a new Makefile target. Done when that target stops unless a released v* tag lists the kit version, has a test covering both cases, and the workflow calls it before npm publish.
Written by the indexing model from the issue text.
Description
The theme kit release should refuse to publish a kit version that no released Gophenberg serves yet.
Current state: the kit publish workflow checks only that the astro@ tag matches the package version. A server runs a theme only when it lists the theme's exact kit patch, and a fresh install picks up a new patch through its caret range. So a kit that reaches npm before any released server lists it breaks every theme rebuilt on it, and a pinned theme stops the server from starting. Today the order is kept by hand.
Proposal: before npm publish, look through the released v* tags and stop unless one of them lists the kit version in internal/themehost/kit.go. Put the check in a Makefile target with a test, as make bump-kit has, and call it from the workflow.
Trigger: the 0.15.1 kit release, where a server patch release had to ship first.
- Dominant language
- Go
- Stars
- 293
- Forks
- 50
- Avg merge
- 15h 38m
- Merged PRs (30d)
- 126
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from gopherium/gophenberg
-
help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
gopherium/gophenberg#554 ·
Maintainers usually reply within 1 day
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
gopherium/gophenberg#548 ·
Maintainers usually reply within 1 day
-
enhancement help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
gopherium/gophenberg#543 ·
Maintainers usually reply within 1 day
-
help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
gopherium/gophenberg#538 · 1 comment ·
Maintainers usually reply within 1 day
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
gopherium/gophenberg#486 ·
Maintainers usually reply within 1 day
All issues in gopherium/gophenberg
Similar issues
-
[BUG] deploy.restart_policy without condition drops the restart policyPossibly taken @akshat-lakhera claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
docker/compose#14383 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
AvengeMedia/dank-greeter#39 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
dokku/dokku-datastore#367 ·
Maintainers usually reply within 1 day
-
[Bug]: ap gateway image build cannot find local policies on WindowsPossibly taken @Jayzilva claimed this today. OpenAspect/Configuration Severity/Major
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
wso2/api-platform#3912 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days