A task's contact cannot be linked, changed or removed after the task is created
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- go, graphql, react, sql, typescript
- Domain
- backend-api-design, database, frontend, full-stack
Research direction
Read TaskScreen.tsx, NewTaskScreen.tsx and operations.ts for the contact field and save flow, then trace UpdateTaskInput through tasks.go, changes.go and the UpdateTask query. Run the named graph and task detail tests to check setting, changing, clearing and preserving a contact when contactId is absent. Done means the task page supports those contact actions with a persistent label, and invalid or cross-tenant contacts are rejected.
Written by the indexing model from the issue text.
Description
What happens
The New task form has a "Link a contact" field. The task page has none. A linked contact shows only as a bare link above the Title field, with no label. A task with no contact shows nothing. So you cannot link a contact later, swap it or remove it. On the New task form, the label also goes once a contact is picked.
The graph cannot do it either. UpdateTaskInput has no contactId, task.Changes has no contact, and the UpdateTask query never sets contact_id.
What should happen
The task page shows the contact field after Priority, as the New task form does. With no contact it shows the search. With one, it shows Maria Perez as a link to her contact page and a "Remove Maria Perez" button. The field keeps one visible label in both states, on both screens.
WordPress draws one form for a new page and a saved page. Its Parent field keeps its label, shows None or the parent's title, and lets you search for another page or clear it, before and after the first save.
updateTask takes contactId the way it takes dueTime: absent keeps the contact, null clears it, an id sets it. Save sends it only when it changed, as timeChange does for the time. The resolver reads the contact through the contact store first, so a deleted contact or one from another tenant is refused with a plain error.
A graph test sets, changes and clears the contact, and proves an absent contactId keeps it. Detail tests link, swap and remove a contact.
Where
frontend/src/tasks/TaskScreen.tsx,TaskFormandContactLinkfrontend/src/tasks/NewTaskScreen.tsx,ContactPicker, moved to its own filefrontend/src/index.css,.alphone-tasks__contactand.alphone-tasks__pickedfrontend/src/tasks/operations.ts,updateTaskMutationgraph/schema/tasks.graphqls,UpdateTaskInputinternal/graphres/tasks.go,taskChangesinternal/task/changes.go,ChangesandApplyinternal/postgres/queries.sql,UpdateTaskinternal/graphres/mutations_test.goandfrontend/src/test/task-detail.test.tsx
- Dominant language
- Go
- Stars
- 287
- Forks
- 64
- Avg merge
- 13h 36m
- Merged PRs (30d)
- 59
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from gopherium/AlphOne
-
good first issue help wanted javascript
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
All issues in gopherium/AlphOne
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
FiloSottile/age#758 ·
-
nginx configOpen
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 2 days
-
fix: the buttons mock cannot take back the match point -- its undo looks only for the running matchOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
stuttgart-things/zaehlwerk#168 ·
Maintainers usually reply within 1 day