client_secret.json without project_id: silent fallback to ambient gcloud ADC quota_project_id escapes CONFIG_DIR isolation
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- rust
- Domain
- authentication, cli
Research direction
Start by tracing quota-project resolution from the binding's client_secret.json to the ambient application_default_credentials.json, using the raw Discovery call in the reproduction as the entry point. Add a regression check for a missing project_id with ADC quota_project_id present, and verify that the binding does not use the ambient project and follows one of the stated expected behaviors.
Written by the indexing model from the issue text.
Description
Description
When client_secret.json has no project_id field, gws does not omit the x-goog-user-project quota project — it silently falls back to the ambient gcloud ADC quota_project_id read from ~/.config/gcloud/application_default_credentials.json.
Two problems:
- It escapes
GOOGLE_WORKSPACE_CLI_CONFIG_DIRisolation. The whole point of pointingCONFIG_DIRat a self-contained directory is that the binding is defined by that directory. Instead gws reaches outside it into machine-global gcloud state that the user never associated with this binding. - It fails confusingly. The resulting 403 names a project the user has no relationship with, giving no hint that the value came from ADC. This appears to be the same symptom reported in #291 ("403 permission error referencing unknown project ID (not user's project)", closed) but via a different trigger, so it may be worth a regression check there.
Environment
| Detail | Value |
|---|---|
| gws | 0.22.5 |
| OS | macOS (Darwin 25.5.0, arm64) |
| Auth | OAuth desktop-app flow, file keyring backend |
| gcloud ADC | present, with quota_project_id set to an unrelated project |
Steps to Reproduce
- Have gcloud ADC present with a quota project set — i.e.
~/.config/gcloud/application_default_credentials.jsoncontains"quota_project_id": "<unrelated-project-from-adc>". This is the normal state on any machine wheregcloud auth application-default loginhas been run. - Set up a gws binding in an isolated dir:
GOOGLE_WORKSPACE_CLI_CONFIG_DIR=/path/to/binding, with its ownclient_secret.json, and authenticate. - Remove the
project_idkey from/path/to/binding/client_secret.json(leaveclient_id/client_secretintact — OAuth itself does not needproject_id). - Make any raw Discovery call, e.g.:
GOOGLE_WORKSPACE_CLI_CONFIG_DIR=/path/to/binding \ gws gmail users messages get --params '{"userId":"me","id":"<MSG_ID>","format":"minimal"}'
Expected Behavior
With no project_id in the binding's client_secret.json, gws should either:
- omit
x-goog-user-projectentirely (which per #729 is arguably correct for Workspace APIs — quota attributes to the OAuth client automatically); or - fail loudly with a clear message that no quota project is configured for this binding
— but not silently adopt a project from machine-global gcloud state that lives outside the configured CONFIG_DIR.
Actual Behavior
The quota project silently becomes the ADC quota_project_id, and the call 403s against a project the binding never referenced:
{
"error": {
"code": 403,
"message": "Caller does not have required permission to use project <unrelated-project-from-adc>. Grant the caller the roles/serviceusage.serviceUsageConsumer role, or a custom role with the serviceusage.services.use permission, by visiting https://console.developers.google.com/iam-admin/iam?project=<unrelated-project-from-adc> and then retry.",
"reason": "forbidden"
}
}
Restoring project_id flips the named project back to the client's own, confirming the fallback chain is:
client_secret.json project_id → (if absent) ADC quota_project_id → (no "none" option)
Additional Context
Honest scoping — two caveats so this is prioritised correctly:
- The trigger is narrow. A
client_secret.jsondownloaded from the Cloud Console always includesproject_id; I reached this state by removing it deliberately, while probing whether the quota stamp of #729 could be suppressed. Users are most likely to hit it via a hand-edited or hand-assembled client file. - If #729 is fixed by not sending
x-goog-user-projectfor Workspace APIs, this fallback likely becomes moot. I'm filing it separately because the isolation escape is a defect in its own right — a binding scoped byCONFIG_DIRsilently consuming machine-global ADC state is surprising regardless of which project ends up in the header — and because it's a second data point that the quota-project resolution logic is doing more than it needs to.
Possibly related: #857 (GOOGLE_WORKSPACE_CLI_CREDENTIALS_FILE ignored when credentials.enc exists) looks like the same genre — ambient/co-located state overriding an explicitly configured binding.
- Dominant language
- Rust
- Stars
- 32.3k
- Forks
- 2k
- Avg merge
- 16h 3m
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from googleworkspace/cli
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
googleworkspace/cli#984 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
googleworkspace/cli#983 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
googleworkspace/cli#958 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
googleworkspace/cli#921 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
googleworkspace/cli#920 ·
Maintainers usually reply within 1 day
All issues in googleworkspace/cli
Similar issues
-
area:cli area:security bug priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
status: new topic: ga4gh-sdk type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
comp-rbac
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ClickHouse/ClickHouse#131875 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
bug(python): read_transaction raises TypeError on a Rewrite with rewritten indicesPossibly taken @Borg93 claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
lance-format/lance#11117 ·
Maintainers usually reply within 2 days