Adding an option to add HTTP request duration information
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- java
- Domain
- networking
Research direction
Start in google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java around the debug logging referenced near line 890, and trace the request lifecycle and existing logging option. Done means an opt-in debug output includes the HTTP request duration while preserving the existing request and response details.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem? Please describe.
We have the need of getting the HTTP request duration of the remote calls that have been involved within HTTP calls that uses this SDK.
The library already provides an option to enable the debug logging where we can get the full HTTP request and response: https://github.com/googleapis/google-http-java-client/blob/4e3b3c3cebeb8439e729a9f99b58e5fc5e13e2cf/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java#L890
However there is no information about how long the request happened.
Do you have any plan to add the option to add this information when the debug logs is enabled ?
Describe the solution you'd like
An option to show HTTP request duration while enabling debug logging mode.
Describe alternatives you've considered
We added another listener to calculate the request duration and print it as a separate logs, which makes it harder to correlate the request duration with the rest of other information while debugging if a lot of HTTP requests are executed in parallel.
Additional context
N/A
- Dominant language
- Java
- Stars
- 1.4k
- Forks
- 476
- Avg merge
- 10h 47m
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from googleapis/google-http-java-client
-
Core: Validate header names and values to prevent CRLF injectionPossibly taken @insaf021 claimed this 106 days ago. Openpriority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Core: XmlPullParser processes external DTD entities (XXE) — disable FEATURE_PROCESS_DOCDECL in Xml#createParser()Possibly taken @insaf021 claimed this 106 days ago. Openpriority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Core: LowLevelHttpResponse not disconnected when HttpResponse construction throws RuntimeExceptionPossibly taken @insaf021 claimed this 106 days ago. Openpriority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
type: cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
org.apache.http.conn.ssl.SSLSocketFactory is deprecatedMay be free again A pull request for this issue was closed without being merged. Openpriority: p2 type: cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
All issues in googleapis/google-http-java-client
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 2/5 Under an hour Newbie friendliness 84/100
cpp-best-practices/project_validator#251 ·
Maintainers usually reply within 1 day
-
backend enhancement
Difficulty 2/5 Half a day Newbie friendliness 70/100
damodharg6/payledger#16 ·
-
[Bug]: An initiative list with no current entry logs an error on every changePossibly taken @dwizard0 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day