[async REST] Remove guards for async rest transport and async client generation once async REST support is GA
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- python
- Domain
- build-system, tooling
Research direction
Start by reading rest_asyncio.py.j2 and async_client.py.j2, focusing on the experimental-feature guards around generated code. Inspect the generator’s output for GAPICs and confirm that rest_asyncio.py and async_client.py are produced unconditionally once async REST support is GA.
Written by the indexing model from the issue text.
Description
Once support for async REST transport goes from experimental -> GA,
we need to remove the following conditions that guard the generation of the async rest transport and the async client:
from rest_asyncio.py.j2:
{% set rest_async_io_enabled = api.all_library_settings[api.naming.proto_package].python_settings.experimental_features.rest_async_io_enabled %}
{% if rest_async_io_enabled %}
..code
{% endif %}{# if rest_async_io_enabled #}
from async_client.py.j2:
{% set rest_async_io_enabled = api.all_library_settings[api.naming.proto_package].python_settings.experimental_features.rest_async_io_enabled %}
{% set is_grpc_transport = True if 'grpc' in opts.transport else False %}
{% if rest_async_io_enabled or is_grpc_transport %}
..code
{% endif %}{# if rest_async_io_enabled and is_grpc_transport #}
Making this change wil generate the relevant files i.e rest_asyncio.py and async_client.py unconditionally for GAPICs.
- Dominant language
- Python
- Stars
- 5.4k
- Forks
- 1.8k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 93
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from googleapis/google-cloud-python
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
googleapis/google-cloud-python#18428 ·
-
priority: p2 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
googleapis/google-cloud-python#18375 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 76/100
googleapis/google-cloud-python#18339 ·
-
auth priority: p2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
googleapis/google-cloud-python#18315 ·
-
priority: p2 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
googleapis/google-cloud-python#18260 ·
All issues in googleapis/google-cloud-python
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100