Clean up new system tests
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start by reviewing PR 7695 and its discussion, then inventory the tests/System/bootstrap.php files, environment-variable definitions, PROJECT_ID usages, and TestHelpers usage. Consolidate or remove bootstrap files where possible, standardize project environment variables and test helpers, and run the affected system tests to confirm the workflow remains consistent.
Written by the indexing model from the issue text.
Description
PR https://github.com/googleapis/google-cloud-php/pull/7695 introduced system tests as part of our workflow, but there's still a lot of work to be done.
- As mentioned in https://github.com/googleapis/google-cloud-php/pull/7695#discussion_r1778955348, we should keep all ENV vars in one place and define them as constants
- Remove
tests/System/bootstrap.phpfiles if possible, or consolidate them to use one inCore - Cleanup use of
PROJECT_IDenvironment variable, in favor ofGOOGLE_PROJECT_ID,GOOGLE_CLOUD_PROJECT, or remove it all together - Cleanup use of
TestHelpersto make all tests consistent.
- Dominant language
- PHP
- Stars
- 1.2k
- Forks
- 464
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 103
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from googleapis/google-cloud-php
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
googleapis/google-cloud-php#9730 ·
-
type: feature request
Difficulty 1/5 Under an hour Newbie friendliness 75/100
googleapis/google-cloud-php#9716 · 11 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
googleapis/google-cloud-php#9725 ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
googleapis/google-cloud-php#9675 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
googleapis/google-cloud-php#9674 · 1 comment ·
All issues in googleapis/google-cloud-php
Similar issues
-
tooling
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
UX
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
ProfessionalWiki/NeoWiki#1525 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
OpenConext/OpenConext-engineblock#2122 ·
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/safe-publish#594 ·