[Auth]: Features to remove for V2
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Active
- Tech stack
- php
- Domain
- authentication
Research direction
Start by reviewing the implementations and usages of getLastReceivedToken, tokenCallback, IAM, IamTrait, FetchAuthTokenCache, and the listed interfaces. Trace how $httpHandler, token validation, and credential metadata currently flow before deciding which V2 removals or consolidations are feasible. Done means the agreed V2 design is implemented consistently and covered by the relevant tests.
Written by the indexing model from the issue text.
Description
This is a list of items we want to change / remove in the next major release
- Remove all instances of
getLastReceivedToken - Remove all instances of
tokenCallback - The constructor of
IAMshould not contain$httpHandler- this should be passed in at runtime - Consider removing
IAMin favor of usingIamTraitin the credentials which use it. - Remove
FetchAuthTokenCachein favor ofCacheTrait - Consider adding
$headersas second argument toFetchAuthTokenIterface::fetchAuthToken, or consolidate everything to useupdateMetadata - Consider consolidating
FetchAuthTokenInterface,UpdateMetadataInterface,ProjectIdProviderInterface,GetQuotaProjectInterface, andGetUniverseDomainInterfaceinto aCredentialInterface. - Consider removing
HttpClientCache, as$httpHandlercan already be passed in everywhere - Remove
Guzzle6HttpHandler - Remove
IAMCredentials - Move to Firebase JWT for token validation (https://github.com/googleapis/google-auth-library-php/pull/554)
- Dominant language
- PHP
- Stars
- 1.2k
- Forks
- 464
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 103
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from googleapis/google-cloud-php
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
googleapis/google-cloud-php#9730 ·
-
type: feature request
Difficulty 1/5 Under an hour Newbie friendliness 75/100
googleapis/google-cloud-php#9716 · 11 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
googleapis/google-cloud-php#9725 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
googleapis/google-cloud-php#9674 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
googleapis/google-cloud-php#9503 ·
All issues in googleapis/google-cloud-php
Similar issues
-
tooling
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
UX
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
ProfessionalWiki/NeoWiki#1525 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
OpenConext/OpenConext-engineblock#2122 ·
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/safe-publish#594 ·